[jira] [Commented] (AIRFLOW-5867) [--debug] unit_test_mode configuration interpreted as str instead of bool

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16969521#comment-16969521 ] 

ASF GitHub Bot commented on AIRFLOW-5867:
-----------------------------------------

rvanasa commented on pull request #6517: [AIRFLOW-5867] Fix webserver unit_test_mode data type
URL: https://github.com/apache/airflow/pull/6517
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5867
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   The `--debug` CLI argument appears to have unintended functionality:
   
   https://github.com/apache/airflow/blob/master/airflow/bin/cli.py#L980
   
   Because `testing` and consequently `app.config['TESTING']` are provided as a `str` object, the reloader is only enabled when the `unit_test_mode` property is an empty string. 
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   This bugfix restores intended functionality. 
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [--debug] unit_test_mode configuration interpreted as str instead of bool
> -------------------------------------------------------------------------
>
>                 Key: AIRFLOW-5867
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5867
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: cli
>    Affects Versions: 1.10.6
>            Reporter: Ryan Vandersmith
>            Assignee: Ryan Vandersmith
>            Priority: Minor
>              Labels: easyfix, pull-request-available
>             Fix For: 1.10.7
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> The `--debug` CLI argument appears to have unintended functionality:
> [https://github.com/apache/airflow/blob/master/airflow/bin/cli.py#L980]
> {code:python}
> if args.debug:
>         print(
>             "Starting the web server on port {0} and host {1}.".format(
>                 args.port, args.hostname))
>         app, _ = create_app(None, testing=conf.get('core', 'unit_test_mode'))
>         app.run(debug=True, use_reloader=not app.config['TESTING'],
>                 port=args.port, host=args.hostname,
>                 ssl_context=(ssl_cert, ssl_key) if ssl_cert and ssl_key else None)
> {code}
> Because `testing` and consequently `app.config['TESTING']` are provided as a `str` object, the reloader is only enabled when the `unit_test_mode` property is an empty string. 
> A very clean fix exists (line 979):
> {code:java}
> app, _ = create_app(None, testing=conf.getboolean('core', 'unit_test_mode'))
> {code}
> I will submit a pull request with the above change immediately after opening this issue. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)