You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena <se...@cloudera.com> on 2017/04/21 21:22:10 UTC
Review Request 58631: SENTRY-1691: TransactionManager should use
try-with-resource for timers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58631/
-----------------------------------------------------------
Review request for sentry.
Bugs: SENTRY-1691
https://issues.apache.org/jira/browse/SENTRY-1691
Repository: sentry
Description
-------
Moved the timer() inside the try-with-resources.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java fb7c40a4d32f6c5588b277c637e041ca8b3d999e
Diff: https://reviews.apache.org/r/58631/diff/1/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 58631: SENTRY-1691: TransactionManager should use
try-with-resource for timers
Posted by kalyan kumar kalvagadda <kk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58631/#review172804
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java
Line 109 (original), 109 (patched)
<https://reviews.apache.org/r/58631/#comment245849>
Sergio, Just wondering what is the advatage of doing it this way?
- kalyan kumar kalvagadda
On April 21, 2017, 9:22 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58631/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:22 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1691
> https://issues.apache.org/jira/browse/SENTRY-1691
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Moved the timer() inside the try-with-resources.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java fb7c40a4d32f6c5588b277c637e041ca8b3d999e
>
>
> Diff: https://reviews.apache.org/r/58631/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 58631: SENTRY-1691: TransactionManager should use
try-with-resource for timers
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58631/#review172802
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On April 21, 2017, 9:22 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58631/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:22 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1691
> https://issues.apache.org/jira/browse/SENTRY-1691
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Moved the timer() inside the try-with-resources.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java fb7c40a4d32f6c5588b277c637e041ca8b3d999e
>
>
> Diff: https://reviews.apache.org/r/58631/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 58631: SENTRY-1691: TransactionManager should use
try-with-resource for timers
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58631/#review172714
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On April 21, 2017, 9:22 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58631/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 9:22 p.m.)
>
>
> Review request for sentry.
>
>
> Bugs: SENTRY-1691
> https://issues.apache.org/jira/browse/SENTRY-1691
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Moved the timer() inside the try-with-resources.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/TransactionManager.java fb7c40a4d32f6c5588b277c637e041ca8b3d999e
>
>
> Diff: https://reviews.apache.org/r/58631/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>