[GitHub] [activemq-artemis] cshannon commented on issue #2802: ARTEMIS-2457 implement ring queue

[GitBox <gi...@apache.org>]

cshannon commented on issue #2802: ARTEMIS-2457 implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#issuecomment-523399739
 
 
   This is kind of nit picky but I would prefer a different name like "FixedSizeQueue" instead of "RingQueue" or something just because the name RingQueue immediately made me think of Ring/Circular buffers where memory is re-used for performance so I thought this would be something similar to LMAX Disruptor, etc.  However, obviously the goal here is to just to maintain a max size or fix sized queue by acking the oldest message.  But I'm certainly not going to -1 over the name, if everyone wants to keep RingQueue that's fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services