You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2012/07/31 01:00:47 UTC

[jira] [Created] (POOL-226) GenericKeyedObjectPool.ObjectTimestampPair fields could be made final without breaking compat?

Sebb created POOL-226:
-------------------------

             Summary: GenericKeyedObjectPool.ObjectTimestampPair fields could be made final without breaking compat?
                 Key: POOL-226
                 URL: https://issues.apache.org/jira/browse/POOL-226
             Project: Commons Pool
          Issue Type: Improvement
            Reporter: Sebb
            Priority: Minor


The package protected static class GenericKeyedObjectPool.ObjectTimestampPair contains two fields which are currently deprecated, pending making them final and private.

Since the fields are package protected, surely they should only be used by Commons Pool code? Does it make sense that any external code would use the fields? 
Indeed can they be used?

If the fields cannot legitimately be used by 3rd party code, then surely there's no need to wait for a major release to change them?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (POOL-226) GenericKeyedObjectPool.ObjectTimestampPair fields could be made final without breaking compat?

Posted by "Mark Thomas (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/POOL-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426080#comment-13426080 ] 

Mark Thomas commented on POOL-226:
----------------------------------

That class is removed entirely in Pool2 anyway.

Personally, I am fine with making them private and final now.
                
> GenericKeyedObjectPool.ObjectTimestampPair fields could be made final without breaking compat?
> ----------------------------------------------------------------------------------------------
>
>                 Key: POOL-226
>                 URL: https://issues.apache.org/jira/browse/POOL-226
>             Project: Commons Pool
>          Issue Type: Improvement
>            Reporter: Sebb
>            Priority: Minor
>
> The package protected static class GenericKeyedObjectPool.ObjectTimestampPair contains two fields which are currently deprecated, pending making them final and private.
> Since the fields are package protected, surely they should only be used by Commons Pool code? Does it make sense that any external code would use the fields? 
> Indeed can they be used?
> If the fields cannot legitimately be used by 3rd party code, then surely there's no need to wait for a major release to change them?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira