[GitHub] merlimat commented on a change in pull request #817: Client times out requests in batch rather than individually

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #817: Client times out requests in batch rather than individually
URL: https://github.com/apache/bookkeeper/pull/817#discussion_r156185189
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
 ##########
 @@ -182,6 +184,19 @@ public Integer getSample() {
                                               }
                                           });
         initializeExplicitLacFlushPolicy();
+
+        if (bk.getConf().getAddEntryQuorumTimeout() > 0) {
+            SafeRunnable monitor = new SafeRunnable() {
 
 Review comment:
   I had added something for that in MangedLedger code: 
   https://github.com/apache/incubator-pulsar/blob/master/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/util/SafeRun.java
   
   They way it's used is like: 
   
   ```java
   executor.submit(safeRun(() -> {
    // ....
   });
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services