[GitHub] [tvm] u99127 commented on a change in pull request #6982: [ETHOSN] Add support for default Ethos-N78 configuration.

[GitBox <gi...@apache.org>]

u99127 commented on a change in pull request #6982:
URL: https://github.com/apache/tvm/pull/6982#discussion_r574455441



##########
File path: src/relay/backend/contrib/ethosn/capabilities.h
##########
@@ -38,13 +39,14 @@ namespace relay {
 namespace contrib {
 namespace ethosn {
 
-/* Ethos-N variants (N77, N57 and N37)
+/* Ethos-N variants (N77, N57, N37 and N78)

Review comment:
       Please fix this to have the proper names, Ethos-N77, Ethos-N37, Ethos-N57 and Ethos-N78.

##########
File path: tests/scripts/task_python_integration.sh
##########
@@ -55,6 +55,9 @@ TVM_FFI=ctypes python3 -m pytest apps/dso_plugin_module
 # TVM_FFI=ctypes sh prepare_and_test_tfop_module.sh
 
 TVM_FFI=ctypes python3 -m pytest tests/python/integration
+if python -c "import tvm; from tvm.relay.op.contrib.ethosn import ethosn_available; print(ethosn_available().name)" -eq "SW_ONLY"; then
+  ETHOSN_VARIANT_CONFIG=ETHOSN78_1TOPS_4PLE_448KSRAM TVM_FFI=ctypes python3 -m pytest tests/python/contrib/test_ethosn

Review comment:
       this logic also needs to be in tests/scripts/task_python_ethosn_tests.sh so that folks just running the tests for Ethos-N77 can get the tests clean 
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org