You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/23 07:09:43 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #1372: [Doc] Document directory rectification [en metrics-tracing]

Alonexc opened a new issue, #1372:
URL: https://github.com/apache/incubator-eventmesh/issues/1372

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Documentation Related
   
   Move the documents under directory https://github.com/apache/incubator-eventmesh/tree/master/docs/en/metrics-tracing 
   to directory https://github.com/apache/incubator-eventmesh/tree/master/docs/en/design-document,and delete the metrics-tracing directory.
   notice:The names of documents moved to design document should be sorted by number.
   eg:
   <img width="292" alt="image" src="https://user-images.githubusercontent.com/91315508/191908425-79fdecef-4f9d-4590-94ee-27cc35b38282.png">
   
   Then the next file should start with 11-.
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen closed issue #1372: [Doc] Document directory rectification [en metrics-tracing]

Posted by GitBox <gi...@apache.org>.
qqeasonchen closed issue #1372: [Doc] Document directory rectification [en metrics-tracing]
URL: https://github.com/apache/incubator-eventmesh/issues/1372


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] eshikarya commented on issue #1372: [Doc] Document directory rectification [en metrics-tracing]

Posted by GitBox <gi...@apache.org>.
eshikarya commented on issue #1372:
URL: https://github.com/apache/incubator-eventmesh/issues/1372#issuecomment-1256026885

   The description requires us to delete the metrics-tracing directory, won't that delete the json file present inside it as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] Alonexc commented on issue #1372: [Doc] Document directory rectification [en metrics-tracing]

Posted by GitBox <gi...@apache.org>.
Alonexc commented on issue #1372:
URL: https://github.com/apache/incubator-eventmesh/issues/1372#issuecomment-1256021350

   You only need to move the document. The json file in the metrics tracing directory does not need to be moved to the design document directory.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] eshikarya commented on issue #1372: [Doc] Document directory rectification [en metrics-tracing]

Posted by GitBox <gi...@apache.org>.
eshikarya commented on issue #1372:
URL: https://github.com/apache/incubator-eventmesh/issues/1372#issuecomment-1255993840

   Hi! I'm new to Open Source contribution, and would like to get started with this.
   Please let me know if I can work on this?
   (I can see 2 _category_.json files in each folder, is there some specific format to be followed to rename them? )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] eshikarya commented on issue #1372: [Doc] Document directory rectification [en metrics-tracing]

Posted by GitBox <gi...@apache.org>.
eshikarya commented on issue #1372:
URL: https://github.com/apache/incubator-eventmesh/issues/1372#issuecomment-1256034347

   @Alonexc Got it! Please assign this to me.
   
   Also pls clarify, based on the description, we need to delete the metrics-tracing directory, which will delete the json file present inside it. Is that alright?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] eshikarya commented on issue #1372: [Doc] Document directory rectification [en metrics-tracing]

Posted by GitBox <gi...@apache.org>.
eshikarya commented on issue #1372:
URL: https://github.com/apache/incubator-eventmesh/issues/1372#issuecomment-1257793422

   @qqeasonchen based on our previous conversation, I tried to clone and do the requested changes.
   I found out that there were certain files which are automatically staged for commit as soon as I clone the project into my local repo, I stashed the files, and then tried to do the required changes to commit them. This brought down the files changed from 68 to 13. I'm not sure why or how this is happening considering I'm not handling any other files except the 2 that need to be moved.
   
   I further tried to the same changes through GitHub to see if I can bring down files changed, it was 3 as we expect it to be but the tests are failing for this, so I'm a little unsure about how to proceed with this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org

[GitHub] [incubator-eventmesh] qqeasonchen commented on issue #1372: [Doc] Document directory rectification [en metrics-tracing]

Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on issue #1372:
URL: https://github.com/apache/incubator-eventmesh/issues/1372#issuecomment-1256067274

   @eshikarya sure ok.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org