[GitHub] [ozone] adoroszlai commented on pull request #1865: HDDS-4769. Simplify insert operation of ContainerAttribute

[GitBox <gi...@apache.org>]

adoroszlai commented on pull request #1865:
URL: https://github.com/apache/ozone/pull/1865#issuecomment-772338943


   > I think it will return _false_ when the ContainerID already exists in the NavigableSet?
   
   You're right.  Then:
   
   ```
   attributeMap
       .computeIfAbsent(key, any -> new TreeSet<>())
       .add(value);
   return true;
   ```
   
   Anyway, I don't think we need to prepare now for fields maybe being added to containerID in the future.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org