You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/10/29 18:30:12 UTC
[GitHub] [geode] jhutchison commented on a change in pull request #5678: GEODE-8663: update Redis Info command To include additional statistics
jhutchison commented on a change in pull request #5678:
URL: https://github.com/apache/geode/pull/5678#discussion_r514478654
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/data/CommandHelper.java
##########
@@ -84,7 +84,13 @@ RedisData getRedisData(ByteArrayWrapper key, RedisData notFoundValue) {
}
RedisSet getRedisSet(ByteArrayWrapper key) {
- return checkSetType(getRedisData(key, NULL_REDIS_SET));
+ RedisData redisData = getRedisData(key, NULL_REDIS_SET);
+ if (redisData == NULL_REDIS_SET) {
+ redisStats.incKeyspaceMisses();
+ } else {
+ redisStats.incKeyspaceHits();
Review comment:
will address in future stories that are coming to investigate overall functionality of this piece
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org