You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/09/15 06:49:19 UTC

[PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

gnodet opened a new pull request, #26451:
URL: https://github.com/apache/camel/pull/26451

## Summary

Fix metadata mismatches between `@UriParam` annotations and actual runtime behaviour in 7 components. All were confirmed on main.

## Root Cause & Fix

### 1. azure-storage-datalake: Wrong `enums` on `operation`
`DataLakeConfiguration.operation` had `enums = "listFileSystem, listFiles"` but `DataLakeOperationsDefinition` has **15 values**. The hardcoded `enums` attribute overrides what the annotation processor would derive from the enum type. **Fix:** remove the `enums` attribute so the processor uses the actual enum constants.

### 2. google-secret-manager: Incomplete `enums` on `operation`
`GoogleSecretManagerConfiguration.operation` had `enums = "createSecret"` but `GoogleSecretManagerOperations` has **4 values** (`createSecret`, `getSecretVersion`, `deleteSecret`, `listSecrets`). **Fix:** remove the `enums` attribute.

### 3. google-storage: `objectName` labelled `producer`-only
`GoogleCloudStorageConfiguration.objectName` was labelled `producer` but `GoogleCloudStorageConsumer` uses `getConfiguration().getObjectName()` to filter which object to read. **Fix:** change label to `common`.

### 4. web3j: `operation` labelled `producer`-only
`Web3jConfiguration.operation` was labelled `producer` but `Web3jConsumer.process()` dispatches on `configuration.getOperation()` to route requests. **Fix:** change label to `common`.

### 5. grpc: `forwardOnCompleted`/`forwardOnError` labelled `consumer`-only
Both flags were labelled `consumer` but `GrpcResponseRouterStreamObserver` (the producer-side streaming client, created via `GrpcStreamObserverFactory`) checks both via `configuration.isForwardOnError()` and `configuration.isForwardOnCompleted()`. **Fix:** change labels to `common`.

### 6. netty-http: `bootstrapConfiguration` invisible in metadata
`NettyHttpComponent.createEndpoint()` extracts `bootstrapConfiguration` via `resolveAndRemoveReferenceParameter` before the parameter map reaches the endpoint. It is completely absent from `@UriParam` annotations, making it invisible in all generated metadata. **Fix:** add a doc-only `@UriParam` field in `NettyHttpEndpoint` with `javaType = "org.apache.camel.component.netty.NettyServerBootstrapConfiguration"`, matching the pattern already used for `httpConfiguration` in the same class.

### 7. jt400: `outputFieldsIdx`/`fieldsLength` String setters have no `@UriParam`
`Jt400Configuration` annotated `Integer[] outputFieldsIdxArray` and `Integer[] outputFieldsLengthArray` with `@UriParam`, but users cannot set `Integer[]` from a URI string. The String-accepting setters `setOutputFieldsIdx(String)` and `setFieldsLength(String)` (which parse comma-separated values into the arrays) existed but had no annotation and no getter — invisible in metadata and unreachable via URI. **Fix:** introduce `String outputFieldsIdx` and `String fieldsLength` fields with `@UriParam`, add corresponding getters, update the setters to also store the string value for round-trip, and remove `@UriParam` from the Integer[] array fields.

## Test

All 7 affected modules compile cleanly (`mvn compile -q`). The azure-storage-datalake generated JSON was regenerated by the annotation processor and now lists all 15 enum values instead of the stale 2.

---
_Hermes Agent (Claude Sonnet 4.6) on behalf of Guillaume Nodet_

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.

gnodet-bot commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5676043025

   <!-- camel-backport-bot -->
   
   ### 🔄 Backport Bot
   
   This bugfix targets `main` and may need porting to:
   - `camel-4.22.x`
   
   Labels `port/<branch>` have been added. Remove a label to opt out of porting to that branch.
   
   Port PRs will be created automatically when this PR is merged. Comment `/port` to create them now.
   
   ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.

gnodet commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5677619783

   Fixed in 76d79caee74b — added `.trim()` in both `setOutputFieldsIdx` and `setFieldsLength` before calling `Integer.parseInt()`, addressing the `NumberFormatException` risk when URI params contain spaces after commas.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5679054685

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `catalog/camel-catalog`
   - `components/camel-azure/camel-azure-storage-datalake`
   - `components/camel-google/camel-google-secret-manager`
   - `components/camel-google/camel-google-storage`
   - `components/camel-grpc`
   - `components/camel-jt400`
   - `components/camel-netty-http`
   - `components/camel-web3j`
   - `dsl/camel-componentdsl`
   - `dsl/camel-endpointdsl`
   
   > :information_source: Dependent modules were not tested because the total number of affected modules exceeded the threshold (50). Use the `test-dependents` label to force testing all dependents.
   
   ---
   
   <details><summary>:microscope: Scalpel shadow comparison — Scalpel: 41 tested, 24 compile-only — current: 38 all tested</summary>
   
   [Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **65 affected modules** (current approach: 38).
   
   <details><summary>:warning: Modules only in Scalpel (27)</summary>
   
   - `apache-camel`
   - `camel-allcomponents`
   - `camel-catalog`
   - `camel-catalog-console`
   - `camel-catalog-maven`
   - `camel-catalog-suggest`
   - `camel-componentdsl`
   - `camel-endpointdsl`
   - `camel-endpointdsl-support`
   - `camel-itest`
   - `camel-jbang-core`
   - `camel-jbang-it`
   - `camel-jbang-main`
   - `camel-jbang-plugin-edit`
   - `camel-jbang-plugin-generate`
   - `camel-jbang-plugin-kubernetes`
   - `camel-jbang-plugin-test`
   - `camel-kamelet-main`
   - `camel-launcher`
   - `camel-report-maven-plugin`
   - `camel-route-parser`
   - `camel-yaml-dsl`
   - `camel-yaml-dsl-deserializers`
   - `camel-yaml-dsl-maven-plugin`
   - `coverage`
   - `docs`
   - `dummy-component`
   
   </details>
   
   **Skip-tests mode would test 41 modules** (10 direct + 31 downstream), **skip tests for 24** (generated code, meta-modules)
   
   <details><summary>Modules Scalpel would test (41)</summary>
   
   - `camel-a2a`
   - `camel-azure-storage-datalake`
   - `camel-catalog`
   - `camel-clickup`
   - `camel-componentdsl`
   - `camel-endpointdsl`
   - `camel-google-secret-manager`
   - `camel-google-storage`
   - `camel-grpc`
   - `camel-java-joor-dsl`
   - `camel-jbang-mcp`
   - `camel-jbang-plugin-mcp`
   - `camel-jbang-plugin-route-parser`
   - `camel-jbang-plugin-tui`
   - `camel-jbang-plugin-validate`
   - `camel-jsonpath`
   - `camel-jt400`
   - `camel-knative-http`
   - `camel-launcher-container`
   - `camel-mcp-server`
   - `camel-micrometer-prometheus`
   - `camel-netty-http`
   - `camel-oauth`
   - `camel-observability-services`
   - `camel-openapi-validator`
   - `camel-platform-http-main`
   - `camel-platform-http-vertx`
   - `camel-rest-openapi`
   - `camel-state-store`
   - `camel-telegram`
   - `camel-test-main-junit5`
   - `camel-test-main-junit6`
   - `camel-web3j`
   - `camel-webhook`
   - `camel-whatsapp`
   - `camel-xml-io-dsl`
   - `camel-xml-jaxb-dsl`
   - `camel-xml-jaxb-dsl-test-definition`
   - `camel-xml-jaxb-dsl-test-spring`
   - `camel-yaml-dsl-validator`
   - `camel-yaml-dsl-validator-maven-plugin`
   
   </details>
   
   <details><summary>Modules with tests skipped (24)</summary>
   
   - `apache-camel`
   - `camel-allcomponents`
   - `camel-catalog-console`
   - `camel-catalog-maven`
   - `camel-catalog-suggest`
   - `camel-endpointdsl-support`
   - `camel-itest`
   - `camel-jbang-core`
   - `camel-jbang-it`
   - `camel-jbang-main`
   - `camel-jbang-plugin-edit`
   - `camel-jbang-plugin-generate`
   - `camel-jbang-plugin-kubernetes`
   - `camel-jbang-plugin-test`
   - `camel-kamelet-main`
   - `camel-launcher`
   - `camel-report-maven-plugin`
   - `camel-route-parser`
   - `camel-yaml-dsl`
   - `camel-yaml-dsl-deserializers`
   - `camel-yaml-dsl-maven-plugin`
   - `coverage`
   - `docs`
   - `dummy-component`
   
   </details>
   
   > :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
   
   </details>
   
   <details><summary>Build reactor — dependencies compiled but only changed modules were tested (10 modules, 1m 56s total)</summary>
   
   **Total reactor time:** 1m 56s
   
   | Module | Duration | Status |
   | --- | --- | --- |
   | Camel :: Component DSL | 53.3s | SUCCESS |
   | Camel :: Web3j | 16.9s | SUCCESS |
   | Camel :: gRPC | 11.8s | SUCCESS |
   | Camel :: Catalog :: Camel Catalog | 11.1s | SUCCESS |
   | Camel :: Google :: Storage | 8.9s | SUCCESS |
   | Camel :: Azure :: Storage Datalake | 6.5s | SUCCESS |
   | Camel :: Java Toolbox for IBM i | 4.0s | SUCCESS |
   | Camel :: Google :: Secret Manager | 3.4s | SUCCESS |
   | Camel :: Endpoint DSL | n/a |  |
   | Camel :: Netty HTTP | n/a |  |
   
   **Top 20 slowest modules:**
   - `Camel :: Component DSL` (53.3s)
   - `Camel :: Web3j` (16.9s)
   - `Camel :: gRPC` (11.8s)
   - `Camel :: Catalog :: Camel Catalog` (11.1s)
   - `Camel :: Google :: Storage` (8.9s)
   - `Camel :: Azure :: Storage Datalake` (6.5s)
   - `Camel :: Java Toolbox for IBM i` (4.0s)
   - `Camel :: Google :: Secret Manager` (3.4s)
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/34955195030)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.

gnodet-bot commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5694661675

   <!-- camel-backport-bot -->
   
   ### 🔄 Backport Bot
   
   **Conflicts (🤖 agent dispatched to resolve):**
   - ⚠️ `camel-4.22.x` — Command failed: gh pr create --repo apache/camel --base camel-4.22.x --head gnodet-bot:backport/26451-to-camel-4.22.x --title [backport camel-4.22.x] CAMEL-24748: Fix component metadata mismatches in 7 components --body <!-- camel-backport-bot -->
   
   ## Backport of #26451
   
   Cherry-pick of #26451 onto `camel-4.22.x`.
   
   **Original PR:** #26451 - CAMEL-24748: Fix component metadata mismatches in 7 components
   **Original author:** @gnodet
   **Target branch:** `camel-4.22.x`
    --label backport,components,dsl,components-azure --assignee gnodet
   pull request update failed: GraphQL: gnodet-bot does not have permission to update the pull request PR_kwDOAAMl7c8AAAABDvG2Xg. (updatePullRequest)
   
   
   ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5676048264

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.

gnodet commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5681759709

   CI is green ✅ and all review findings have been resolved. The outstanding `CHANGES_REQUESTED` from @apupier (compile failure in `camel-netty-http`) was fixed several commits ago — real accessors were added and the generated configurer was regenerated. Subsequent re-reviews from gnodet-bot and an approval from @davsclaus confirm all 7 metadata fixes are correct and complete.
   
   The PR is ready to merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.

gnodet merged PR #26451:
URL: https://github.com/apache/camel/pull/26451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.

gnodet-bot commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5694725086

   <!-- camel-backport-bot -->
   
   ### 🔄 Backport Bot
   
   **Port PRs updated:**
   - 🔄 `camel-4.22.x` → #26497 (force-pushed)
   
   ℹ️ If you push additional commits after `/port`, use `/port` again to update the port PRs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.

gnodet commented on code in PR #26451:
URL: https://github.com/apache/camel/pull/26451#discussion_r4013877530


##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpEndpoint.java:
##########
@@ -230,6 +235,18 @@ public void setNettySharedHttpServer(NettySharedHttpServer nettySharedHttpServer
         this.nettySharedHttpServer = nettySharedHttpServer;
     }
 
+    public NettyServerBootstrapConfiguration getBootstrapConfiguration() {
+        return bootstrapConfiguration;
+    }
+
+    /**
+     * To use a custom configured NettyServerBootstrapConfiguration for configuring this endpoint. When set, its
+     * properties are merged into the endpoint configuration.
+     */
+    public void setBootstrapConfiguration(NettyServerBootstrapConfiguration bootstrapConfiguration) {
+        this.bootstrapConfiguration = bootstrapConfiguration;

Review Comment:
   Fixed in e8b89b65882f: removed `@UriParam` from the field (the type `NettyServerBootstrapConfiguration` is itself `@UriParams`, so the annotation processor expands it rather than emitting a simple object-reference entry — the generated configurer/UriFactory/JSON were not consistent with what the processor actually produces). The getter/setter with Javadoc are retained. Regenerated artifacts committed.



##########
components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConfiguration.java:
##########
@@ -100,10 +100,10 @@ public class GrpcConfiguration {
     @UriParam(label = "consumer", defaultValue = "PROPAGATION", enums = "AGGREGATION,PROPAGATION,DELEGATION")
     private GrpcConsumerStrategy consumerStrategy = GrpcConsumerStrategy.PROPAGATION;
 
-    @UriParam(label = "consumer", defaultValue = "false")
+    @UriParam(label = "common", defaultValue = "false")
     private boolean forwardOnCompleted;

Review Comment:
   Fixed in 76ea4c71cd04: grpc.json and catalog/components/grpc.json regenerated with forwardOnCompleted/forwardOnError in group 'common'.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.

gnodet commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5677522120

   Addressed all review findings:
   
   **@apupier / @oscerd / @gnodet-bot** — commits `76ea4c7` and `982cc78`:
   
   1. **Missing regenerated sources (grpc + jt400)** — committed the annotation-processor output for both:
      - `camel-grpc`: `grpc.json` updated with `forwardOnCompleted`/`forwardOnError` in group `common`; catalog JSON updated to match
      - `camel-jt400`: `Jt400EndpointConfigurer`, `Jt400EndpointUriFactory`, `jt400.json` regenerated with `outputFieldsIdx`/`fieldsLength` (String) replacing the old `Integer[]` params; catalog JSON updated to match
      - The uncommitted-generated-files gate should now pass
   
   2. **`bootstrapConfiguration` Javadoc** — clarified that the parameter is URI-resolved by `NettyHttpComponent.createEndpoint()` and is not applied when set programmatically via the setter
   
   The compile failure (netty-http configurer calling non-existent accessors) was already fixed in the previous push with the typed `NettyServerBootstrapConfiguration` field + real getters/setters.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #26451:
URL: https://github.com/apache/camel/pull/26451#issuecomment-5678067846

   <!-- regen-patch -->
   ### :warning: Generated files are out of date
   
   The [CI build](https://github.com/apache/camel/actions/runs/34950724368) regenerated files that are not committed on this PR.
   
   If *Allow edits from maintainers* is enabled, a maintainer bot will automatically
   push a "Regen" commit to this branch shortly.
   
   Otherwise, you can apply the patch manually — the missing changes are available
   as the `regen-patch` artifact of that run:
   
   ```bash
   gh pr checkout 26451 --repo apache/camel
   gh run download 34950724368 --repo apache/camel -n regen-patch
   git apply --index regen.patch && rm regen.patch pr-number
   git commit -m "Regen" && git push
   ```
   
   Alternatively, run `./etc/scripts/regen.sh` locally and commit the resulting changes.
   If the patch does not apply cleanly, update the branch from the base branch first —
   the patch was generated against the merge with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet-bot (via GitHub)" <gi...@apache.org>.

gnodet-bot commented on code in PR #26451:
URL: https://github.com/apache/camel/pull/26451#discussion_r4013815772


##########
components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConfiguration.java:
##########
@@ -100,10 +100,10 @@ public class GrpcConfiguration {
     @UriParam(label = "consumer", defaultValue = "PROPAGATION", enums = "AGGREGATION,PROPAGATION,DELEGATION")
     private GrpcConsumerStrategy consumerStrategy = GrpcConsumerStrategy.PROPAGATION;
 
-    @UriParam(label = "consumer", defaultValue = "false")
+    @UriParam(label = "common", defaultValue = "false")
     private boolean forwardOnCompleted;

Review Comment:
   🔴 **Missing regen:** label changed from `consumer` to `common` here (and on `forwardOnError` below) but the regenerated `camel-grpc` catalog JSON and adoc are not in the commit. Run `mvn install -pl components/camel-grpc -q` and commit the generated files.



##########
components/camel-jt400/src/main/java/org/apache/camel/component/jt400/Jt400Configuration.java:
##########
@@ -147,10 +147,16 @@ public String getJt400Value() {
     @UriParam(label = "consumer", defaultValue = "EQ")
     private SearchType searchType = SearchType.EQ;
 
-    @UriParam(label = "producer")
+    @UriParam(label = "producer",
+              description = "Specifies which fields (program parameters) are output parameters, as a comma-separated list of 0-based indexes.")
+    private String outputFieldsIdx;

Review Comment:
   🔴 **Missing regen:** new `@UriParam` fields here (and `fieldsLength` at line 156) will be picked up by the annotation processor, updating the jt400 component JSON, the endpoint configurer, and the adoc. None of those generated files are committed. Run `mvn install -pl components/camel-jt400 -q` and commit the output.



##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpEndpoint.java:
##########
@@ -230,6 +235,18 @@ public void setNettySharedHttpServer(NettySharedHttpServer nettySharedHttpServer
         this.nettySharedHttpServer = nettySharedHttpServer;
     }
 
+    public NettyServerBootstrapConfiguration getBootstrapConfiguration() {
+        return bootstrapConfiguration;
+    }
+
+    /**
+     * To use a custom configured NettyServerBootstrapConfiguration for configuring this endpoint. When set, its
+     * properties are merged into the endpoint configuration.
+     */
+    public void setBootstrapConfiguration(NettyServerBootstrapConfiguration bootstrapConfiguration) {
+        this.bootstrapConfiguration = bootstrapConfiguration;

Review Comment:
   ℹ️ **Dead setter for non-URI paths:** when `bootstrapConfiguration` is supplied via URI, the component extracts and removes it before endpoint binding — this setter is never reached. When supplied via Spring XML or programmatic `setBootstrapConfiguration(...)`, the field is stored but nothing reads it to apply the merge. The comment on the field hints at this, but the public setter creates a false expectation. Add explicit Javadoc: `@param bootstrapConfiguration Only effective when set via URI reference (resolveAndRemoveReferenceParameter); has no effect when set programmatically.`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.

gnodet commented on code in PR #26451:
URL: https://github.com/apache/camel/pull/26451#discussion_r4013869772


##########
components/camel-grpc/src/main/java/org/apache/camel/component/grpc/GrpcConfiguration.java:
##########
@@ -100,10 +100,10 @@ public class GrpcConfiguration {
     @UriParam(label = "consumer", defaultValue = "PROPAGATION", enums = "AGGREGATION,PROPAGATION,DELEGATION")
     private GrpcConsumerStrategy consumerStrategy = GrpcConsumerStrategy.PROPAGATION;
 
-    @UriParam(label = "consumer", defaultValue = "false")
+    @UriParam(label = "common", defaultValue = "false")
     private boolean forwardOnCompleted;

Review Comment:
   Fixed in 76ea4c71cd04 — added missing regenerated sources for camel-grpc.



##########
components/camel-jt400/src/main/java/org/apache/camel/component/jt400/Jt400Configuration.java:
##########
@@ -147,10 +147,16 @@ public String getJt400Value() {
     @UriParam(label = "consumer", defaultValue = "EQ")
     private SearchType searchType = SearchType.EQ;
 
-    @UriParam(label = "producer")
+    @UriParam(label = "producer",
+              description = "Specifies which fields (program parameters) are output parameters, as a comma-separated list of 0-based indexes.")
+    private String outputFieldsIdx;

Review Comment:
   Fixed in 76ea4c71cd04 — added missing regenerated sources for camel-jt400.



##########
components/camel-netty-http/src/main/java/org/apache/camel/component/netty/http/NettyHttpEndpoint.java:
##########
@@ -230,6 +235,18 @@ public void setNettySharedHttpServer(NettySharedHttpServer nettySharedHttpServer
         this.nettySharedHttpServer = nettySharedHttpServer;
     }
 
+    public NettyServerBootstrapConfiguration getBootstrapConfiguration() {
+        return bootstrapConfiguration;
+    }
+
+    /**
+     * To use a custom configured NettyServerBootstrapConfiguration for configuring this endpoint. When set, its
+     * properties are merged into the endpoint configuration.
+     */
+    public void setBootstrapConfiguration(NettyServerBootstrapConfiguration bootstrapConfiguration) {
+        this.bootstrapConfiguration = bootstrapConfiguration;

Review Comment:
   Addressed in 982cc78a282a — added explicit Javadoc noting that the setter is only effective when set via URI reference and has no effect when set programmatically.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] CAMEL-24748: Fix component metadata mismatches in 7 components [camel]

Posted by "gnodet (via GitHub)" <gi...@apache.org>.

gnodet commented on code in PR #26451:
URL: https://github.com/apache/camel/pull/26451#discussion_r4013879258


##########
components/camel-jt400/src/main/java/org/apache/camel/component/jt400/Jt400Configuration.java:
##########
@@ -147,10 +147,16 @@ public String getJt400Value() {
     @UriParam(label = "consumer", defaultValue = "EQ")
     private SearchType searchType = SearchType.EQ;
 
-    @UriParam(label = "producer")
+    @UriParam(label = "producer",
+              description = "Specifies which fields (program parameters) are output parameters, as a comma-separated list of 0-based indexes.")
+    private String outputFieldsIdx;

Review Comment:
   Fixed in 76ea4c71cd04: Jt400EndpointConfigurer, Jt400EndpointUriFactory, jt400.json, and catalog/components/jt400.json all regenerated with the new outputFieldsIdx/fieldsLength String fields.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org