You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Jörg Steffens <jo...@dass-it.de> on 2010/05/05 16:49:07 UTC

[PATCH] contrib/client-side/asvn: fixes handling of filenames with spaces

[[[
Bugfix for handling variables with spaces in filenames

* contrib/client-side/asvn
  (main): uses "$@" instead of $@

patch by joerg.steffens < at > dass-it.de
]]]

Re: [PATCH] contrib/client-side/asvn: fixes handling of filenames with spaces

Posted by Peter Samuelson <pe...@p12n.org>.
> Bugfix for handling variables with spaces in filenames
> 
> * contrib/client-side/asvn
>   (main): uses "$@" instead of $@
> 
> patch by joerg.steffens < at > dass-it.de

r941728.

Even though, as Hyrum says, we are not really maintaining the 'contrib'
tree anymore ... this patch is simple and obviously correct.
-- 
Peter Samuelson | org-tld!p12n!peter | http://p12n.org/

Re: [PATCH] contrib/client-side/asvn: fixes handling of filenames with spaces

Posted by Jörg Steffens <jo...@dass-it.de>.
[Peter Samuelson]
> [Jörg Steffens]
>> * contrib/client-side/asvn
>>   (main): uses "$@" instead of $@
> 
> That's fine.
> 
>> @@ -384,16 +412,17 @@
>>  case "$1" in
>>    checkout|co)      CHDIR=true; ACTION="post";;
>>    commit|ci)        ACTION="pre";;
>> +  status|st)        ACTION="pre";;
>>    switch|sw)        ACTION="post";;
>>    update|up)        ACTION="post";;
>>    *);;
> 
> Was this supposed to be part of the patch?

you are right. This part should be a separate patch.
New patch is attached.

Same description as before:
[[[
Bugfix for handling variables with spaces in filenames

* contrib/client-side/asvn
  (main): uses "$@" instead of $@

patch by joerg.steffens < at > dass-it.de
]]]



-- 
  Jörg Steffens            joerg.steffens@dass-it.de
  dass IT GmbH             Phone: +49.221.3565666-91
  http://www.dass-IT.de      Fax: +49.221.3565666-10

 Sitz der Gesellschaft: Köln | Amtsgericht Köln: HRB52500
 Geschäftsführer: S. Dühr, M. Außendorf, Jörg Steffens, P. Storz

Re: [PATCH] contrib/client-side/asvn: fixes handling of filenames with spaces

Posted by Jörg Steffens <jo...@dass-it.de>.
[Peter Samuelson]
> [Jörg Steffens]
>> * contrib/client-side/asvn
>>   (main): uses "$@" instead of $@
> 
> That's fine.
> 
>> @@ -384,16 +412,17 @@
>>  case "$1" in
>>    checkout|co)      CHDIR=true; ACTION="post";;
>>    commit|ci)        ACTION="pre";;
>> +  status|st)        ACTION="pre";;
>>    switch|sw)        ACTION="post";;
>>    update|up)        ACTION="post";;
>>    *);;
> 
> Was this supposed to be part of the patch?

you are right. This part should be a separate patch.
New patch is attached.

Same description as before:
[[[
Bugfix for handling variables with spaces in filenames

* contrib/client-side/asvn
  (main): uses "$@" instead of $@

patch by joerg.steffens < at > dass-it.de
]]]



-- 
  Jörg Steffens            joerg.steffens@dass-it.de
  dass IT GmbH             Phone: +49.221.3565666-91
  http://www.dass-IT.de      Fax: +49.221.3565666-10

 Sitz der Gesellschaft: Köln | Amtsgericht Köln: HRB52500
 Geschäftsführer: S. Dühr, M. Außendorf, Jörg Steffens, P. Storz

Re: [PATCH] contrib/client-side/asvn: fixes handling of filenames with spaces

Posted by Peter Samuelson <pe...@p12n.org>.
[Jörg Steffens]
> * contrib/client-side/asvn
>   (main): uses "$@" instead of $@

That's fine.

> @@ -384,16 +412,17 @@
>  case "$1" in
>    checkout|co)      CHDIR=true; ACTION="post";;
>    commit|ci)        ACTION="pre";;
> +  status|st)        ACTION="pre";;
>    switch|sw)        ACTION="post";;
>    update|up)        ACTION="post";;
>    *);;

Was this supposed to be part of the patch?

Re: [PATCH] contrib/client-side/asvn: fixes handling of filenames with spaces

Posted by Peter Samuelson <pe...@p12n.org>.
[Jörg Steffens]
> * contrib/client-side/asvn
>   (main): uses "$@" instead of $@

That's fine.

> @@ -384,16 +412,17 @@
>  case "$1" in
>    checkout|co)      CHDIR=true; ACTION="post";;
>    commit|ci)        ACTION="pre";;
> +  status|st)        ACTION="pre";;
>    switch|sw)        ACTION="post";;
>    update|up)        ACTION="post";;
>    *);;

Was this supposed to be part of the patch?