You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/02/07 10:28:34 UTC

[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #236: feat(apis):refactor apis for CPP styles

ShannonDing opened a new pull request #236: feat(apis):refactor apis for CPP styles
URL: https://github.com/apache/rocketmq-client-cpp/pull/236
 
 
   ## What is the purpose of the change
   
   eat(apis):refactor apis for CPP styles
   
   ## Brief changelog
   eat(apis):refactor apis for CPP styles
   
   ## Verifying this change
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] ShannonDing opened a new pull request #236: feat(apis):refactor apis for CPP styles

Posted by GitBox <gi...@apache.org>.
ShannonDing opened a new pull request #236: feat(apis):refactor apis for CPP styles
URL: https://github.com/apache/rocketmq-client-cpp/pull/236
 
 
   ## What is the purpose of the change
   
   eat(apis):refactor apis for CPP styles
   
   ## Brief changelog
   eat(apis):refactor apis for CPP styles
   
   ## Verifying this change
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #236: feat(apis):refactor apis for CPP styles

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #236: feat(apis):refactor apis for CPP styles
URL: https://github.com/apache/rocketmq-client-cpp/pull/236#issuecomment-583354922
 
 
   # [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236?src=pr&el=h1) Report
   > Merging [#236](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/7151454ace1e5cb3a762d5e52bcd2791a8d087c3?src=pr&el=desc) will **increase** coverage by `0.18%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/graphs/tree.svg?width=650&token=L5As3jdqFW&height=150&src=pr)](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #236      +/-   ##
   ==========================================
   + Coverage   52.18%   52.36%   +0.18%     
   ==========================================
     Files         178      178              
     Lines       11337    11349      +12     
   ==========================================
   + Hits         5916     5943      +27     
   + Misses       5421     5406      -15
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [include/AsyncCallback.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-aW5jbHVkZS9Bc3luY0NhbGxiYWNrLmg=) | `66.66% <ø> (ø)` | :arrow_up: |
   | [include/MQSelector.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-aW5jbHVkZS9NUVNlbGVjdG9yLmg=) | `0% <ø> (ø)` | :arrow_up: |
   | [include/MQMessage.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-aW5jbHVkZS9NUU1lc3NhZ2UuaA==) | `71.42% <ø> (ø)` | :arrow_up: |
   | [include/MQClientException.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-aW5jbHVkZS9NUUNsaWVudEV4Y2VwdGlvbi5o) | `81.81% <ø> (ø)` | :arrow_up: |
   | [include/PullResult.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-aW5jbHVkZS9QdWxsUmVzdWx0Lmg=) | `100% <ø> (ø)` | :arrow_up: |
   | [include/MQMessageQueue.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-aW5jbHVkZS9NUU1lc3NhZ2VRdWV1ZS5o) | `100% <ø> (ø)` | :arrow_up: |
   | [include/SendResult.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-aW5jbHVkZS9TZW5kUmVzdWx0Lmg=) | `0% <ø> (ø)` | :arrow_up: |
   | [include/MQMessageExt.h](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-aW5jbHVkZS9NUU1lc3NhZ2VFeHQuaA==) | `100% <ø> (ø)` | :arrow_up: |
   | [src/consumer/DefaultMQPushConsumer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL0RlZmF1bHRNUVB1c2hDb25zdW1lci5jcHA=) | `51.11% <ø> (+1.11%)` | :arrow_up: |
   | [src/consumer/DefaultMQPullConsumer.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree#diff-c3JjL2NvbnN1bWVyL0RlZmF1bHRNUVB1bGxDb25zdW1lci5jcHA=) | `34.78% <ø> (+0.97%)` | :arrow_up: |
   | ... and [4 more](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236?src=pr&el=footer). Last update [7151454...9061e67](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/236?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] ShannonDing closed pull request #236: feat(apis):refactor apis for CPP styles

Posted by GitBox <gi...@apache.org>.
ShannonDing closed pull request #236: feat(apis):refactor apis for CPP styles
URL: https://github.com/apache/rocketmq-client-cpp/pull/236
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq-client-cpp] ShannonDing merged pull request #236: feat(apis):refactor apis for CPP styles

Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #236: feat(apis):refactor apis for CPP styles
URL: https://github.com/apache/rocketmq-client-cpp/pull/236
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services