You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/05/26 15:38:53 UTC

[GitHub] [incubator-pekko-http] pjfanning opened a new pull request, #160: upgrade pekko snapshot

pjfanning opened a new pull request, #160:
URL: https://github.com/apache/incubator-pekko-http/pull/160

   to get a version that uses Scala 3.3.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning merged pull request #160: upgrade pekko snapshot

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #160:
URL: https://github.com/apache/incubator-pekko-http/pull/160


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] mdedetrich commented on a diff in pull request #160: upgrade pekko snapshot

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #160:
URL: https://github.com/apache/incubator-pekko-http/pull/160#discussion_r1207005003


##########
project/PekkoDependency.scala:
##########
@@ -53,7 +53,7 @@ object PekkoDependency {
   }
 
   // Default version updated only when needed, https://pekko.apache.org/docs/pekko/current/project/downstream-upgrade-strategy.html
-  val minimumExpectedPekkoVersion = "0.0.0+26656-898c6970-SNAPSHOT"
+  val minimumExpectedPekkoVersion = "0.0.0+26671-d5a1b2ef-SNAPSHOT"

Review Comment:
   Can we change this to `0.0.0+26669-ec5b6764-SNAPSHOT`, otherwise we get dependency conflicts and I remember you changing some other pekko module to `0.0.0+26669-ec5b6764-SNAPSHOT` when Scala 3 was merged into it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


[GitHub] [incubator-pekko-http] pjfanning commented on a diff in pull request #160: upgrade pekko snapshot

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #160:
URL: https://github.com/apache/incubator-pekko-http/pull/160#discussion_r1207009273


##########
project/PekkoDependency.scala:
##########
@@ -53,7 +53,7 @@ object PekkoDependency {
   }
 
   // Default version updated only when needed, https://pekko.apache.org/docs/pekko/current/project/downstream-upgrade-strategy.html
-  val minimumExpectedPekkoVersion = "0.0.0+26656-898c6970-SNAPSHOT"
+  val minimumExpectedPekkoVersion = "0.0.0+26671-d5a1b2ef-SNAPSHOT"

Review Comment:
   switched



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org