[GitHub] [airflow] acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust

[GitBox <gi...@apache.org>]

acroos commented on a change in pull request #6380: [AIRFLOW-3632] Allow replace_microseconds in trigger_dag REST reqeust
URL: https://github.com/apache/airflow/pull/6380#discussion_r337264637
 
 

 ##########
 File path: airflow/www/api/experimental/endpoints.py
 ##########
 @@ -74,8 +75,12 @@ def trigger_dag(dag_id):
 
             return response
 
+    replace_microseconds = True
+    if 'replace_microseconds' in data:
+        replace_microseconds = to_boolean(data['replace_microseconds'])
+
     try:
-        dr = trigger.trigger_dag(dag_id, run_id, conf, execution_date)
+        dr = trigger.trigger_dag(dag_id, run_id, conf, execution_date, replace_microseconds)
 
 Review comment:
   yeah that seems much nicer.  I felt like passing `'replace_microseconds': 'false'` in the request body felt a bit odd, but didn't want to make _too_ big of a change to start with.  I'll make the changes in the morning

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services