You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/12 17:58:30 UTC
[GitHub] [helix] dasahcc commented on a change in pull request #1251: Add totalMessageReceivedCounter and decrepcate old totalMessageReceived
dasahcc commented on a change in pull request #1251:
URL: https://github.com/apache/helix/pull/1251#discussion_r469440929
##########
File path: helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java
##########
@@ -71,8 +71,9 @@
private SimpleDynamicMetric<Long> _successTopStateHandoffCounter;
private SimpleDynamicMetric<Long> _failedTopStateHandoffCounter;
private SimpleDynamicMetric<Long> _maxSinglePartitionTopStateHandoffDuration;
- private SimpleDynamicMetric<Long> _totalMessageReceived;
-
+ @Deprecated
+ private SimpleDynamicMetric<Long> _totalMessageReceived; // This should be counter but it is not now
Review comment:
Sure. Let me add the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org