You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/11/28 20:13:45 UTC

[GitHub] anirudh2290 commented on a change in pull request #13433: Fix deconvolution / PR 13421

anirudh2290 commented on a change in pull request #13433: Fix deconvolution  / PR 13421
URL: https://github.com/apache/incubator-mxnet/pull/13433#discussion_r237244148
 
 

 ##########
 File path: tests/python/mkl/test_mkldnn.py
 ##########
 @@ -398,6 +398,24 @@ def softmax_forward(input_data, true_output):
     softmax_forward(mx.nd.array([[[[-3.4e38,-3.4e38]]]]), np.array([1.0,1.0]))
     softmax_forward(mx.nd.array([[[[3.4e38,3.4e38]]]]), np.array([1.0,1.0]))
 
+@with_seed(12345)
 
 Review comment:
   @TaoLv do you mean tests/python/unittest/test_operator.py. The tests in tests/python/gpu/test_operator_gpu.py are only meant to run with gpu context.
   I see that there are tests in tests/python/unittest/test_operator.py for deconv but they are also skipped because of flakiness. Doesnt seem like we have any coverage on the Deconvolution operator

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services