You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/12 12:11:43 UTC

[GitHub] [spark] maropu commented on pull request #30353: [SPARK-33431][CORE][SQL]Use Option.contains instead of instanceOfOption == Some(x)

maropu commented on pull request #30353:
URL: https://github.com/apache/spark/pull/30353#issuecomment-726040046


   > Before:
   option == Some(x)
   Some(x) != option
    After:
   option == Some(x)
   Some(x) != option
   
   Seems the before/after examples in the description are the same?
   
   Anyway, the changes sound reasonable. The other sub-modules (e.g., mllib) do not have the pattern (`option == Some(x)`)?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org