[GitHub] [incubator-iceberg] johnclara opened a new pull request #324: Optimistically query and replace files atomically

[GitBox <gi...@apache.org>]

johnclara opened a new pull request #324: Optimistically query and replace files atomically
URL: https://github.com/apache/incubator-iceberg/pull/324
 
 
   Fixes #316 
   
   Hi, I'm trying to learn about iceberg.
   
   One option to perform the copy-on-write/eager updates is to provide the queryTime snapshot to the ReplaceFiles SnapshotProducer. Then if the snapshot is not the queryTime snapshot, fail the commit.
   
   I'm hoping this doesn't get retried because it is an IllegalStateException and not a CommitFailedException.
   
   excerpt from base SnapshotProducer
   ```
         Tasks.foreach(ops)
             .retry(base.propertyAsInt(COMMIT_NUM_RETRIES, COMMIT_NUM_RETRIES_DEFAULT))
             .exponentialBackoff(
                 base.propertyAsInt(COMMIT_MIN_RETRY_WAIT_MS, COMMIT_MIN_RETRY_WAIT_MS_DEFAULT),
                 base.propertyAsInt(COMMIT_MAX_RETRY_WAIT_MS, COMMIT_MAX_RETRY_WAIT_MS_DEFAULT),
                 base.propertyAsInt(COMMIT_TOTAL_RETRY_TIME_MS, COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT),
                 2.0 /* exponential */)
             .onlyRetryOn(CommitFailedException.class)
             .run(taskOps -> {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org