You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2015/03/09 14:01:34 UTC
[GitHub] spark pull request: [SPARK-6224][SQL] Also collect NamedExpression...
GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/4949
[SPARK-6224][SQL] Also collect NamedExpressions in PhysicalOperation
Currently in `PhysicalOperation`, only `Alias` expressions are collected. Similarly, `NamedExpression` can be collected for substitution.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 collect_namedexpr
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4949
----
commit cee75657aa30239c094b2b7d7671815b4adac5eb
Author: Liang-Chi Hsieh <vi...@gmail.com>
Date: 2015-03-09T12:57:12Z
Also collect NamedExpressions in PhysicalOperation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6224][SQL] Also collect NamedExpression...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4949#issuecomment-77853448
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28390/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6224][SQL] Also collect NamedExpression...
Posted by viirya <gi...@git.apache.org>.
Github user viirya closed the pull request at:
https://github.com/apache/spark/pull/4949
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6224][SQL] Also collect NamedExpression...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4949#issuecomment-77853437
[Test build #28390 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28390/consoleFull) for PR 4949 at commit [`cee7565`](https://github.com/apache/spark/commit/cee75657aa30239c094b2b7d7671815b4adac5eb).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-6224][SQL] Also collect NamedExpression...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4949#issuecomment-77848861
[Test build #28390 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/28390/consoleFull) for PR 4949 at commit [`cee7565`](https://github.com/apache/spark/commit/cee75657aa30239c094b2b7d7671815b4adac5eb).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org