[GitHub] [fineract] francisguchie commented on pull request #1597: Add condition to start TLS (FINERACT-1070)

[GitBox <gi...@apache.org>]

francisguchie commented on pull request #1597:
URL: https://github.com/apache/fineract/pull/1597#issuecomment-793909487


   @ptuomola  this PR originated from my findings written in https://issues.apache.org/jira/browse/FINERACT-1070 
   @vorburger  too after looking through my findings, he was in agreement 
   
   Somewhere along the line, we needed to get the real problem so @BLasan  hard-coded the parameters and also logged some critical information for me to test on a local machine 
   
   We did some functional tests and all was well but the approach used by me even after removing the hard-codes was not of good standard  if you can recall this section below
   
   > **Yuh. Your approach is ok @francisguchie . But instead of excluding that path, @ptuomola suggested to an exclusion for this particular dependency.**
   
   Ultimately the code was fine tuned and all was set for a merge after I did the functional test and the reviews from you and the rest about the code itself was done 
   
   Reason is because in the current build passwords cannot be sent to user via mail and more so any emails cannot be sent by FINERACT since there was an error in the code 
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org