You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/02 02:32:22 UTC

[GitHub] [pulsar] codelipenghui commented on a diff in pull request #18250: [cleanup][broker] Remove duplicate sendSuccess and sendError in PulsarCommandSender

codelipenghui commented on code in PR #18250:
URL: https://github.com/apache/pulsar/pull/18250#discussion_r1011092123


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSender.java:
##########
@@ -72,10 +72,6 @@ void sendLookupResponse(String brokerServiceUrl, String brokerServiceUrlTls, boo
 
     void sendActiveConsumerChange(long consumerId, boolean isActive);
 
-    void sendSuccess(long requestId);

Review Comment:
   @cbornet Do we have some plugins or something using this API? I don't aware of it. Maybe we'd better to add 
   
   ```
   @InterfaceAudience.Public
   @InterfaceStability.Stable
   ```
   
   For the public APIs.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org