You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by jm...@apache.org on 2013/05/14 03:47:41 UTC
[3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns
may not be committed yet initialiseHeaderInfo needs to use the column array
passed not the internal one. Method is also called for non grouped columns.
Caused the occasional RTE when comb
As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called for non grouped columns. Caused the occasional RTE when combined with changing columns at run time.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/8133e4ff
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/8133e4ff
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/8133e4ff
Branch: refs/heads/develop
Commit: 8133e4ffde5a188314ad32b7a50a17405ae0fe1f
Parents: 0a5f1fb
Author: Justin Mclean <jm...@apache.org>
Authored: Tue May 14 11:47:20 2013 +1000
Committer: Justin Mclean <jm...@apache.org>
Committed: Tue May 14 11:47:20 2013 +1000
----------------------------------------------------------------------
.../src/mx/controls/AdvancedDataGridBaseEx.as | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/8133e4ff/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as b/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
index b96ad1a..edc4161 100644
--- a/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
+++ b/frameworks/projects/advancedgrids/src/mx/controls/AdvancedDataGridBaseEx.as
@@ -2872,8 +2872,10 @@ public class AdvancedDataGridBaseEx extends AdvancedDataGridBase implements IIME
/**
* @private
+ *
+ * Note columns may not of been committed at this point.
*/
- protected function initializeHeaderInfo(a:Array):Array
+ protected function initializeHeaderInfo(columns:Array):Array
{
var newArray:Array = [];
var n:int = columns.length;
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called for non grouped columns. Caused the occasional RTE whe...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> [1] http://answers.yahoo.com/question/index?qid=20100313060726AAdrIS8
Not quite "would have" -> "would've" which can be misheard as "would of", you don't have the same issue with "not have" (as not've is not exactly common usage). Either way have works for me if you want to change it.
Justin
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the
columns may not be committed yet initialiseHeaderInfo needs to use the
column array passed not the internal one. Method is also called for non
grouped columns. Caused the occasional RTE whe...
Posted by Alex Harui <ah...@adobe.com>.
On 5/13/13 8:28 PM, "OmPrakash Muppirala" <bi...@gmail.com> wrote:
> On May 13, 2013 8:25 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>>
>> Hi,
>>
>>> Shouldn't this be "...may not have been..."?
>> No but change it if you want. Non US English perhaps?
>>
>> Justin
>
> I always thought that was how Australians said that :-)
I don't think it is just Australians. But [1] says I should go and change
it.
[1] http://answers.yahoo.com/question/index?qid=20100313060726AAdrIS8
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the
columns may not be committed yet initialiseHeaderInfo needs to use the column
array passed not the internal one. Method is also called for non grouped
columns. Caused the occasional RTE whe...
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On May 13, 2013 8:25 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
> Hi,
>
> > Shouldn't this be "...may not have been..."?
> No but change it if you want. Non US English perhaps?
>
> Justin
I always thought that was how Australians said that :-)
Om
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the columns may not be committed yet initialiseHeaderInfo needs to use the column array passed not the internal one. Method is also called for non grouped columns. Caused the occasional RTE whe...
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> Shouldn't this be "...may not have been..."?
No but change it if you want. Non US English perhaps?
Justin
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the
columns may not be committed yet initialiseHeaderInfo needs to use the
column array passed not the internal one. Method is also called for non
grouped columns. Caused the occasional RTE whe...
Posted by Alex Harui <ah...@adobe.com>.
On 5/13/13 6:47 PM, "jmclean@apache.org" <jm...@apache.org> wrote:
> AdvancedDataGridBase implements IIME
>
> /**
> * @private
> + *
> + * Note columns may not of been committed at this point.
Shouldn't this be "...may not have been..."?
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui
Re: [3/3] git commit: [flex-sdk] [refs/heads/develop] - As the
columns may not be committed yet initialiseHeaderInfo needs to use the
column array passed not the internal one. Method is also called for non
grouped columns. Caused the occasional RTE whe...
Posted by Alex Harui <ah...@adobe.com>.
On 5/13/13 6:47 PM, "jmclean@apache.org" <jm...@apache.org> wrote:
> AdvancedDataGridBase implements IIME
>
> /**
> * @private
> + *
> + * Note columns may not of been committed at this point.
Shouldn't this be "...may not have been..."?
--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui