You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/01/26 21:44:13 UTC
[GitHub] [bookkeeper] dlg99 opened a new pull request #2555: Fixed: DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
dlg99 opened a new pull request #2555:
URL: https://github.com/apache/bookkeeper/pull/2555
DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Same as https://github.com/apache/bookkeeper/pull/2553 but for master branch
Descriptions of the changes in this PR:
added .initCause for the new FNFE exception to preserver it
### Motivation
got the
ERROR org.apache.bookkeeper.statelib.impl.rocksdb.checkpoint.RocksCheckpointer - Failed to restore rocksdb ...
java.io.FileNotFoundException: ..../metadata
without any additional info for the rootcause (other than stack pointing to the DLCheckpointStore)
DLCheckpointStore appears to re-throw exceptions as FNFE without preserving the rootcause
### Changes
added .initCause
Master Issue: #2552
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks.
>
> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2555: Fixed: DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2555:
URL: https://github.com/apache/bookkeeper/pull/2555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2555: Fixed: DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2555:
URL: https://github.com/apache/bookkeeper/pull/2555#issuecomment-768485461
@dlg99 as you are a committer here you can enter the github action page and click in 'rerun job'. It is quicker than using the magic comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2555: Fixed: DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2555:
URL: https://github.com/apache/bookkeeper/pull/2555#issuecomment-768089676
rerun-failure-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] dlg99 commented on pull request #2555: Fixed: DLCheckpointStore rethrows exceptions as FNFE but swallows the rootcause
Posted by GitBox <gi...@apache.org>.
dlg99 commented on pull request #2555:
URL: https://github.com/apache/bookkeeper/pull/2555#issuecomment-768464806
rerun-failure-tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org