You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/05/31 18:40:02 UTC

[GitHub] wujimin commented on a change in pull request #731: [SCB-617] Graceful shutdown with standalone tomcat

wujimin commented on a change in pull request #731: [SCB-617] Graceful shutdown with standalone tomcat
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/731#discussion_r192198050
 
 

 ##########
 File path: core/src/main/java/org/apache/servicecomb/core/CseApplicationListener.java
 ##########
 @@ -71,6 +72,8 @@ public void onApplicationEvent(ApplicationEvent event) {
       }
 
       SCBEngine.getInstance().init();
+    } else if (event instanceof ContextClosedEvent) {
+      SCBEngine.getInstance().uninit();
 
 Review comment:
   done
   changed all uninit to destroy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services