You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ch...@apache.org on 2016/06/30 17:41:53 UTC

[06/50] [abbrv] incubator-carbondata git commit: [Issue - CARBONDATA-10] Avoid to much logging of timestamp parsing exception in TimeStampDirectDictionaryGenerator (#745)

[Issue - CARBONDATA-10] Avoid to much logging of timestamp parsing exception in TimeStampDirectDictionaryGenerator (#745)



Project: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/commit/d5636db0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/tree/d5636db0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-carbondata/diff/d5636db0

Branch: refs/heads/master
Commit: d5636db0de30d6461381b58d0c2e594470d9e938
Parents: a174f69
Author: Mohammad Shahid Khan <mo...@gmail.com>
Authored: Sat Jun 25 12:59:38 2016 +0530
Committer: Ravindra Pesala <ra...@gmail.com>
Committed: Sat Jun 25 12:59:38 2016 +0530

----------------------------------------------------------------------
 .../timestamp/TimeStampDirectDictionaryGenerator.java         | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-carbondata/blob/d5636db0/core/src/main/java/org/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java b/core/src/main/java/org/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java
index 700a6ee..8493991 100644
--- a/core/src/main/java/org/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java
+++ b/core/src/main/java/org/carbondata/core/keygenerator/directdictionary/timestamp/TimeStampDirectDictionaryGenerator.java
@@ -33,8 +33,6 @@ import static org.carbondata.core.keygenerator.directdictionary.timestamp.TimeSt
 import static org.carbondata.core.keygenerator.directdictionary.timestamp.TimeStampGranularityConstants.TIME_GRAN_MIN;
 import static org.carbondata.core.keygenerator.directdictionary.timestamp.TimeStampGranularityConstants.TIME_GRAN_SEC;
 
-import org.apache.spark.sql.columnar.TIMESTAMP;
-
 /**
  * The class provides the method to generate dictionary key and getting the actual value from
  * the dictionaryKey for direct dictionary column for TIMESTAMP type.
@@ -95,6 +93,9 @@ public class TimeStampDirectDictionaryGenerator implements DirectDictionaryGener
         Date dateToStr = timeParser.parse(cutOffTimeStampString);
         cutOffTimeStampLocal = dateToStr.getTime();
       } catch (ParseException e) {
+        LOGGER.warn("Cannot convert" + cutOffTimeStampString
+            + " to Time/Long type value. Value considered for cutOffTimeStamp is -1." + e
+            .getMessage());
         cutOffTimeStampLocal = -1;
       }
     }
@@ -122,7 +123,7 @@ public class TimeStampDirectDictionaryGenerator implements DirectDictionaryGener
     try {
       dateToStr = timeParser.parse(memberStr);
     } catch (ParseException e) {
-      LOGGER.error("Cannot convert" + TIMESTAMP.toString()
+      LOGGER.debug("Cannot convert " + memberStr
           + " to Time/Long type value. Value considered as null." + e.getMessage());
       dateToStr = null;
     }