You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/28 23:03:20 UTC
[GitHub] [arrow] ovr opened a new pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
ovr opened a new pull request #9037:
URL: https://github.com/apache/arrow/pull/9037
Hello!
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9037:
URL: https://github.com/apache/arrow/pull/9037#issuecomment-751890974
https://issues.apache.org/jira/browse/ARROW-11054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ovr commented on pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
Posted by GitBox <gi...@apache.org>.
ovr commented on pull request #9037:
URL: https://github.com/apache/arrow/pull/9037#issuecomment-751891345
@andygrove I am still working on it, planning to finish today/tomorrow. I will mark this PR to ready for merge after it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ovr commented on pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
Posted by GitBox <gi...@apache.org>.
ovr commented on pull request #9037:
URL: https://github.com/apache/arrow/pull/9037#issuecomment-751901487
I finished, CI passed, I think PR is now ready for review.
Thanks
cC @andygrove
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9037:
URL: https://github.com/apache/arrow/pull/9037#issuecomment-752956456
The full set of Rust CI tests did not run on this PR :(
Can you please rebase this PR against [apache/master](https://github.com/apache/arrow) to pick up the changes in https://github.com/apache/arrow/pull/9056 so that they do?
I apologize for the inconvenience.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9037:
URL: https://github.com/apache/arrow/pull/9037#issuecomment-752974030
Thanks again @ovr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ovr edited a comment on pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
Posted by GitBox <gi...@apache.org>.
ovr edited a comment on pull request #9037:
URL: https://github.com/apache/arrow/pull/9037#issuecomment-751891345
@andygrove I am still working on it, planning to finish today/tomorrow. I will mark this PR to ready for review after it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9037:
URL: https://github.com/apache/arrow/pull/9037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9037: ARROW-11054: [Rust] [DataFusion] Move to sqlparser 0.7.0
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9037:
URL: https://github.com/apache/arrow/pull/9037#issuecomment-752963133
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9037?src=pr&el=h1) Report
> Merging [#9037](https://codecov.io/gh/apache/arrow/pull/9037?src=pr&el=desc) (81141a8) into [master](https://codecov.io/gh/apache/arrow/commit/cf0ef79fe7653aa707191eea78c280d6e501858b?el=desc) (cf0ef79) will **decrease** coverage by `0.02%`.
> The diff coverage is `55.55%`.
[](https://codecov.io/gh/apache/arrow/pull/9037?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9037 +/- ##
==========================================
- Coverage 82.64% 82.61% -0.03%
==========================================
Files 202 202
Lines 50044 50052 +8
==========================================
- Hits 41358 41351 -7
- Misses 8686 8701 +15
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9037?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/sql/parser.rs](https://codecov.io/gh/apache/arrow/pull/9037/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvcGFyc2VyLnJz) | `82.35% <36.36%> (-4.53%)` | :arrow_down: |
| [rust/datafusion/src/sql/planner.rs](https://codecov.io/gh/apache/arrow/pull/9037/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9zcWwvcGxhbm5lci5ycw==) | `83.97% <64.00%> (-0.84%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9037?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9037?src=pr&el=footer). Last update [cf0ef79...81141a8](https://codecov.io/gh/apache/arrow/pull/9037?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org