You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by asmaier <gi...@git.apache.org> on 2016/09/23 13:55:57 UTC
[GitHub] storm pull request #1711: Added ByteKeyValueScheme class.
GitHub user asmaier opened a pull request:
https://github.com/apache/storm/pull/1711
Added ByteKeyValueScheme class.
It is a common use case to send and receive byte key and values via Kafka. Unfortunately the storm-kafka package misses support for this. So I added a ByteKeyValueScheme in analogy to the StringKeyValueScheme class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asmaier/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1711.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1711
----
commit 48e261c466ca7167ead5c9bae2793fd38ccff32c
Author: Andreas Maier <an...@unbelievable-machine.com>
Date: 2016-09-23T13:49:43Z
Added ByteKeyValueScheme class.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1711: STORM-2123: Added ByteKeyValueScheme class.
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1711
@asmaier
Could you make implementation similar to StringKeyValueScheme? It would help us to maintain twos easier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1711: STORM-2123: Added ByteKeyValueScheme class.
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1711
@asmaier Makes sense, and I missed that. Could you also provide a patch for also STORM-2121 if you don't mind? Thanks in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1711: STORM-2123: Added ByteKeyValueScheme class.
Posted by asmaier <gi...@git.apache.org>.
Github user asmaier commented on the issue:
https://github.com/apache/storm/pull/1711
Unfortunately there is a bug in the implementation of StringKeyValueScheme: https://issues.apache.org/jira/browse/STORM-2121
I believe this problem should be fixed first, before changing the implementation of ByteKeyValueScheme.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1711: STORM-2123: Added ByteKeyValueScheme class.
Posted by asmaier <gi...@git.apache.org>.
Github user asmaier commented on the issue:
https://github.com/apache/storm/pull/1711
I created the JIRA ticket STORM-2123 and added an Apache license header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1711: Added ByteKeyValueScheme class.
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the issue:
https://github.com/apache/storm/pull/1711
@asmaier Could you create a JIRA ticket for this and update the title so it's prefixed with the JIRA ID?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1711: Added ByteKeyValueScheme class.
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1711#discussion_r80280538
--- Diff: external/storm-kafka/src/jvm/org/apache/storm/kafka/ByteKeyValueScheme.java ---
@@ -0,0 +1,33 @@
+package org.apache.storm.kafka;
--- End diff --
Need Apache license header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---