You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/25 15:25:55 UTC
[GitHub] [airflow] ngaranko opened a new pull request #14461: BugFix: Set correct Pod State in queue after processing status.
ngaranko opened a new pull request #14461:
URL: https://github.com/apache/airflow/pull/14461
We're facing problems with Pods being endlessly restarted, event after task is successfully completed.
This seems to be result of State being set to `None` instead of `State.SUCCESS`.
This PR fixes state in queue from `None` to `State.SUCCESS` for `Succeeded` events.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ngaranko commented on pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
ngaranko commented on pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#issuecomment-788115028
@dimberman Thank you for taking a look, I'll continue debugging then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ngaranko closed pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
ngaranko closed pull request #14461:
URL: https://github.com/apache/airflow/pull/14461
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on a change in pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
dimberman commented on a change in pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#discussion_r584870174
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -205,7 +205,7 @@ def process_status(
self.watcher_queue.put((pod_id, namespace, State.FAILED, annotations, resource_version))
elif status == 'Succeeded':
self.log.info('Event: %s Succeeded', pod_id)
- self.watcher_queue.put((pod_id, namespace, None, annotations, resource_version))
+ self.watcher_queue.put((pod_id, namespace, State.SUCCESS, annotations, resource_version))
Review comment:
@ngaranko @kaxil this doesn't need to be set in the executor. Successes are set by the worker when the task completes. Maybe we should add a comment explaining this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#discussion_r584781625
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -205,7 +205,7 @@ def process_status(
self.watcher_queue.put((pod_id, namespace, State.FAILED, annotations, resource_version))
elif status == 'Succeeded':
self.log.info('Event: %s Succeeded', pod_id)
- self.watcher_queue.put((pod_id, namespace, None, annotations, resource_version))
+ self.watcher_queue.put((pod_id, namespace, State.SUCCESS, annotations, resource_version))
Review comment:
This has been like this for a long time --- @dimberman Am I missing something here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#issuecomment-785984131
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#issuecomment-788092394
@ngaranko I think there might be something else causing this bug. We don't set successes in the executor. We only set failures in the case where the pod fails before completing. This should be set by the worker.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#issuecomment-788014711
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#discussion_r584783645
##########
File path: airflow/executors/kubernetes_executor.py
##########
@@ -205,7 +205,7 @@ def process_status(
self.watcher_queue.put((pod_id, namespace, State.FAILED, annotations, resource_version))
elif status == 'Succeeded':
self.log.info('Event: %s Succeeded', pod_id)
- self.watcher_queue.put((pod_id, namespace, None, annotations, resource_version))
+ self.watcher_queue.put((pod_id, namespace, State.SUCCESS, annotations, resource_version))
Review comment:
This was changed 3 years back in https://github.com/apache/airflow/pull/3301
cc @dimberman any ideas
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14461: BugFix: Set correct Pod State in queue after processing status.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14461:
URL: https://github.com/apache/airflow/pull/14461#issuecomment-786125852
[The Workflow run](https://github.com/apache/airflow/actions/runs/600437415) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org