You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/18 15:40:47 UTC
[GitHub] [airflow] Aakcht opened a new pull request, #27779: Chart: add airflow_local_settings to all airflow containers
Aakcht opened a new pull request, #27779:
URL: https://github.com/apache/airflow/pull/27779
This PR adds `airflow_local_settings` volume mount to all containers in the chart that use `airflow` command. This allows to reference `airflow_local_settings` file in all airflow containers.
closes: #25637 #27498
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on a diff in pull request #27779: Chart: add airflow_local_settings to all airflow containers
Posted by GitBox <gi...@apache.org>.
Aakcht commented on code in PR #27779:
URL: https://github.com/apache/airflow/pull/27779#discussion_r1034422405
##########
tests/charts/test_cleanup_pods.py:
##########
@@ -239,6 +239,42 @@ def test_should_set_job_history_limits(self):
assert 2 == jmespath.search("spec.failedJobsHistoryLimit", docs[0])
assert 4 == jmespath.search("spec.successfulJobsHistoryLimit", docs[0])
+ def test_no_airflow_local_settings(self):
+ docs = render_chart(
+ values={
+ "cleanup": {
+ "enabled": True,
+ "failedJobsHistoryLimit": 2,
+ "successfulJobsHistoryLimit": 4,
+ },
+ "airflowLocalSettings": None,
+ },
+ show_only=["templates/cleanup/cleanup-cronjob.yaml"],
+ )
+ volume_mounts = jmespath.search(
+ "spec.jobTemplate.spec.template.spec.containers[0].volumeMounts", docs[0]
+ )
+ assert "airflow_local_settings.py" not in str(volume_mounts)
+
+ def test_airflow_local_settings(self):
+ docs = render_chart(
+ values={
+ "cleanup": {
+ "enabled": True,
+ "failedJobsHistoryLimit": 2,
+ "successfulJobsHistoryLimit": 4,
+ },
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a diff in pull request #27779: Chart: add airflow_local_settings to all airflow containers
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on code in PR #27779:
URL: https://github.com/apache/airflow/pull/27779#discussion_r1034190493
##########
tests/charts/test_cleanup_pods.py:
##########
@@ -239,6 +239,42 @@ def test_should_set_job_history_limits(self):
assert 2 == jmespath.search("spec.failedJobsHistoryLimit", docs[0])
assert 4 == jmespath.search("spec.successfulJobsHistoryLimit", docs[0])
+ def test_no_airflow_local_settings(self):
+ docs = render_chart(
+ values={
+ "cleanup": {
+ "enabled": True,
+ "failedJobsHistoryLimit": 2,
+ "successfulJobsHistoryLimit": 4,
+ },
Review Comment:
```suggestion
"cleanup": {"enabled": True},
```
##########
tests/charts/test_cleanup_pods.py:
##########
@@ -239,6 +239,42 @@ def test_should_set_job_history_limits(self):
assert 2 == jmespath.search("spec.failedJobsHistoryLimit", docs[0])
assert 4 == jmespath.search("spec.successfulJobsHistoryLimit", docs[0])
+ def test_no_airflow_local_settings(self):
+ docs = render_chart(
+ values={
+ "cleanup": {
+ "enabled": True,
+ "failedJobsHistoryLimit": 2,
+ "successfulJobsHistoryLimit": 4,
+ },
+ "airflowLocalSettings": None,
+ },
+ show_only=["templates/cleanup/cleanup-cronjob.yaml"],
+ )
+ volume_mounts = jmespath.search(
+ "spec.jobTemplate.spec.template.spec.containers[0].volumeMounts", docs[0]
+ )
+ assert "airflow_local_settings.py" not in str(volume_mounts)
+
+ def test_airflow_local_settings(self):
+ docs = render_chart(
+ values={
+ "cleanup": {
+ "enabled": True,
+ "failedJobsHistoryLimit": 2,
+ "successfulJobsHistoryLimit": 4,
+ },
Review Comment:
```suggestion
"cleanup": {"enabled": True},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Aakcht commented on pull request #27779: Chart: add airflow_local_settings to all airflow containers
Posted by GitBox <gi...@apache.org>.
Aakcht commented on PR #27779:
URL: https://github.com/apache/airflow/pull/27779#issuecomment-1330249368
@jedcunningham I made the suggested changes, please take a look. It seems that the failed check is not related to this PR, so I'll leave it as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #27779: Chart: add airflow_local_settings to all airflow containers
Posted by GitBox <gi...@apache.org>.
jedcunningham merged PR #27779:
URL: https://github.com/apache/airflow/pull/27779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org