You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/16 14:52:11 UTC

[GitHub] [superset] aehanno commented on a diff in pull request #20061: fix: Add french translation missing

aehanno commented on code in PR #20061:
URL: https://github.com/apache/superset/pull/20061#discussion_r873825648


##########
superset-frontend/src/views/CRUD/welcome/Welcome.tsx:
##########
@@ -279,7 +279,7 @@ function Welcome({ user, addDangerToast }: WelcomeProps) {
   return (
     <WelcomeContainer>
       <WelcomeNav>
-        <h1 className="welcome-header">Home</h1>
+        <h1 className="welcome-header">{t('Home')}</h1>

Review Comment:
   correction is in this PR : https://github.com/apache/superset/pull/20078



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org