You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by lvfangmin <gi...@git.apache.org> on 2017/07/31 18:56:59 UTC
[GitHub] zookeeper pull request #321: [ZOOKEEPER-2852] Read snapshotSizeFactor from s...
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/321
[ZOOKEEPER-2852] Read snapshotSizeFactor from system property
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-2852
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/321.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #321
----
commit 07161f36aa63c1ab5abd2753d6e1d734a51d318c
Author: Fangmin Lyu <al...@fb.com>
Date: 2017-07-31T18:56:14Z
read snapshotSizeFactor from system property
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #321: [ZOOKEEPER-2852] Read snapshotSizeFactor from system p...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/321
Committed to master: https://github.com/apache/zookeeper/commit/3f7e4133f3abc17df5eb4f0145d0833417bfdb33
3.5: https://github.com/apache/zookeeper/commit/fce8286684f96441ce7cdf0a9a337027a041e51b
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #321: [ZOOKEEPER-2852] Read snapshotSizeFactor from s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/321
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #321: [ZOOKEEPER-2852] Read snapshotSizeFactor from s...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/321#discussion_r131051673
--- Diff: src/java/main/org/apache/zookeeper/server/ZKDatabase.java ---
@@ -98,6 +98,16 @@ public ZKDatabase(FileTxnSnapLog snapLog) {
dataTree = new DataTree();
sessionsWithTimeouts = new ConcurrentHashMap<Long, Integer>();
this.snapLog = snapLog;
+
+ // Read system property
+ String value = System.getProperty(SNAPSHOT_SIZE_FACTOR, "0.33");
+ try {
+ snapshotSizeFactor = Double.parseDouble(value);
+ } catch (NumberFormatException e) {
+ LOG.error("Error parsing " + SNAPSHOT_SIZE_FACTOR
--- End diff --
Please use parameterized log messages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---