You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Erik Hatcher (JIRA)" <ji...@apache.org> on 2009/08/01 04:04:14 UTC
[jira] Created: (SOLR-1323) XPathEntityProcessor's $hasMore feature
should reset when fetching the next URL
XPathEntityProcessor's $hasMore feature should reset when fetching the next URL
-------------------------------------------------------------------------------
Key: SOLR-1323
URL: https://issues.apache.org/jira/browse/SOLR-1323
Project: Solr
Issue Type: Bug
Components: contrib - DataImportHandler
Reporter: Erik Hatcher
Assignee: Erik Hatcher
Fix For: 1.4
See http://www.lucidimagination.com/search/document/4e266fd420ae5826/dataimporthandler_xpathentityprocessor_hasmore_infinite_loop
Currently if $hasMore is set on a row, it must be reset manually in order for the next URL to not be requested.
It makes more sense for XPathEntityProcessor to reset the $hasMore flag when processed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1323) XPathEntityProcessor's $hasMore
feature should reset when fetching the next URL
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher resolved SOLR-1323.
--------------------------------
Resolution: Fixed
Committed. Thanks for the tweak, Noble.
> XPathEntityProcessor's $hasMore feature should reset when fetching the next URL
> -------------------------------------------------------------------------------
>
> Key: SOLR-1323
> URL: https://issues.apache.org/jira/browse/SOLR-1323
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Fix For: 1.4
>
> Attachments: SOLR-1323.patch, SOLR-1323.patch
>
>
> See http://www.lucidimagination.com/search/document/4e266fd420ae5826/dataimporthandler_xpathentityprocessor_hasmore_infinite_loop
> Currently if $hasMore is set on a row, it must be reset manually in order for the next URL to not be requested.
> It makes more sense for XPathEntityProcessor to reset the $hasMore flag when processed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1323) XPathEntityProcessor's $hasMore feature
should reset when fetching the next URL
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noble Paul updated SOLR-1323:
-----------------------------
Attachment: SOLR-1323.patch
> XPathEntityProcessor's $hasMore feature should reset when fetching the next URL
> -------------------------------------------------------------------------------
>
> Key: SOLR-1323
> URL: https://issues.apache.org/jira/browse/SOLR-1323
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Fix For: 1.4
>
> Attachments: SOLR-1323.patch, SOLR-1323.patch
>
>
> See http://www.lucidimagination.com/search/document/4e266fd420ae5826/dataimporthandler_xpathentityprocessor_hasmore_infinite_loop
> Currently if $hasMore is set on a row, it must be reset manually in order for the next URL to not be requested.
> It makes more sense for XPathEntityProcessor to reset the $hasMore flag when processed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1323) XPathEntityProcessor's $hasMore
feature should reset when fetching the next URL
Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737829#action_12737829 ]
Noble Paul commented on SOLR-1323:
----------------------------------
it should be removed , instead of setting to false. $nextUrl also can be removed along with it
> XPathEntityProcessor's $hasMore feature should reset when fetching the next URL
> -------------------------------------------------------------------------------
>
> Key: SOLR-1323
> URL: https://issues.apache.org/jira/browse/SOLR-1323
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Fix For: 1.4
>
> Attachments: SOLR-1323.patch
>
>
> See http://www.lucidimagination.com/search/document/4e266fd420ae5826/dataimporthandler_xpathentityprocessor_hasmore_infinite_loop
> Currently if $hasMore is set on a row, it must be reset manually in order for the next URL to not be requested.
> It makes more sense for XPathEntityProcessor to reset the $hasMore flag when processed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-1323) XPathEntityProcessor's $hasMore feature
should reset when fetching the next URL
Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher updated SOLR-1323:
-------------------------------
Attachment: SOLR-1323.patch
simple patch to simply set $hasMore to false once it is processed. The scenario mentioned in the e-mail thread is alleviated with this patch. That's the extent of my testing. Anyone see anything wrong? If not, I'll commit in a few days.
> XPathEntityProcessor's $hasMore feature should reset when fetching the next URL
> -------------------------------------------------------------------------------
>
> Key: SOLR-1323
> URL: https://issues.apache.org/jira/browse/SOLR-1323
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Reporter: Erik Hatcher
> Assignee: Erik Hatcher
> Fix For: 1.4
>
> Attachments: SOLR-1323.patch
>
>
> See http://www.lucidimagination.com/search/document/4e266fd420ae5826/dataimporthandler_xpathentityprocessor_hasmore_infinite_loop
> Currently if $hasMore is set on a row, it must be reset manually in order for the next URL to not be requested.
> It makes more sense for XPathEntityProcessor to reset the $hasMore flag when processed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.