You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2019/12/31 02:33:46 UTC
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull
request #16: feature k210
masayuki2009 commented on a change in pull request #16: feature k210
URL: https://github.com/apache/incubator-nuttx/pull/16#discussion_r362137425
##########
File path: include/stdint.h
##########
@@ -273,8 +273,13 @@ typedef _uint64_t uint_fast64_t;
/* Integer types capable of holding object pointers */
+#ifdef __LP64__
+typedef long intptr_t;
+typedef unsigned long uintptr_t;
+#else
typedef _intptr_t intptr_t;
typedef _uintptr_t uintptr_t;
+#endif
Review comment:
@patacongo Thanks for the comment. I understand what I should do. I'll fix the commits and force to push again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [incubator-nuttx] masayuki2009 commented on a change in
pull request #16: feature k210
Posted by Nathan Hartman <ha...@gmail.com>.
On Mon, Dec 30, 2019 at 11:32 PM Gregory Nutt <sp...@gmail.com> wrote:
> > I seemed to have dropped off the face of the earth for a few days
> > because of overtime to get some projects shipped. But I did not
> > forget. I'm working on it now.
>
> Sorry... didn't mean to rush you. If you can get a little more
> framework with some inline writing instructions or whatever, then I will
> try to help more. I don't mean to leave you holding the bag (again).
Hi,
No problem! I work on this with pleasure.
I did some reorganization in the document, banged out some more text,
and added some outline/REVISIT... I hope it's helpful. I've been
struggling with "writer's block" tonight. Feel free to edit/improve
anything you like. Nothing I wrote is set in stone.
It's now well past 1:00 AM for me and I'm getting up early for work,
so I have to call it a night now, but I'll continue working on the
workflow soon. In the meantime, I hope that in addition to you working
on it, other community members will be inspired to do so as well...
Be back soon...
Nathan
Re: [GitHub] [incubator-nuttx] masayuki2009 commented on a change in
pull request #16: feature k210
Posted by Gregory Nutt <sp...@gmail.com>.
> I seemed to have dropped off the face of the earth for a few days
> because of overtime to get some projects shipped. But I did not
> forget. I'm working on it now.
Sorry... didn't mean to rush you. If you can get a little more
framework with some inline writing instructions or whatever, then I will
try to help more. I don't mean to leave you holding the bag (again).
Greg
Re: [GitHub] [incubator-nuttx] masayuki2009 commented on a change in
pull request #16: feature k210
Posted by Nathan Hartman <ha...@gmail.com>.
On Mon, Dec 30, 2019 at 9:42 PM Gregory Nutt <sp...@gmail.com> wrote:
> > Review comment:
> > @patacongo Thanks for the comment. I understand what I should do. I'll fix the commits and force to push again.
>
> No rush. PRs are stuck in the process now. We (actually Nathan) had
> just started the Workflow requirements when the holidays hit us and
> brought everything to a halt (along with some other holiday drama). So
> there is a small backlog building up until we can clearly define that
> Workflow.
>
> Nathan... Do you have an ETA when you will be able to work on the that
> document? I don't mind helping out if you can flesh out the outline a
> little better. It is pretty cryptic in places now.
Hi Greg,
I seemed to have dropped off the face of the earth for a few days
because of overtime to get some projects shipped. But I did not
forget. I'm working on it now.
Nathan
Re: [GitHub] [incubator-nuttx] masayuki2009 commented on a change in
pull request #16: feature k210
Posted by Gregory Nutt <sp...@gmail.com>.
> Review comment:
> @patacongo Thanks for the comment. I understand what I should do. I'll fix the commits and force to push again.
No rush. PRs are stuck in the process now. We (actually Nathan) had
just started the Workflow requirements when the holidays hit us and
brought everything to a halt (along with some other holiday drama). So
there is a small backlog building up until we can clearly define that
Workflow.
Nathan... Do you have an ETA when you will be able to work on the that
document? I don't mind helping out if you can flesh out the outline a
little better. It is pretty cryptic in places now.
Greg