[GitHub] [fineract] taskain7 commented on a diff in pull request #3201: [FINERACT-1926] Initiate transfer on not active loan fix

["taskain7 (via GitHub)" <gi...@apache.org>]

taskain7 commented on code in PR #3201:
URL: https://github.com/apache/fineract/pull/3201#discussion_r1205240184


##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java:
##########
@@ -117,7 +118,8 @@ private void validateSettlementDate(ExternalAssetOwnerTransfer externalAssetOwne
     }
 
     private void validateLoanStatus(LoanIdAndExternalIdData loanIdAndExternalIdAndExternalId) {
-        if (Objects.isNull(loanIdAndExternalIdAndExternalId)) {
+        if (Objects.isNull(loanIdAndExternalIdAndExternalId.getLoanId())

Review Comment:
   fixed
   it's got handled in the `LoanRepositoryWrapper`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org