You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2023/01/31 21:28:09 UTC

[GitHub] [solr] dsmiley commented on pull request #1320: SOLR-16641 - Generate gradle.properties from gradlew

dsmiley commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1411092588

   I suggest for the Windows side, just check if there is no gradle.properties and log a warning pointing at the unix script to help the user craft one themselves.  This is just an idea; I think we can get away with being less thorough in some fashion for Windows as it's used much less and the need for this file is iffy.  We're doing something rather unusual in Lucene & Solr -- insisting on gradle.properties when countless Gradle projects have no such mandate.
   
   A simplifying alternative would be to check gradle.properties into the project (but still marked ignored in .gitignore) and with Gradle's own defaults for number of workers & tests, or choose low ones.  Advise users to edit them according to their machine.  We are overthinking this stuff today!  This has dev maintenance costs we pay right now.  Generating this file is over-engineered IMO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org