[jira] [Commented] (SLING-13233) Multi-feature aggregation: add ,

["Roy Teeuwen (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-13233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18087750#comment-18087750 ] 

Roy Teeuwen commented on SLING-13233:
-------------------------------------

[~rombert]  done, created two PRs that covers the two cases :). 

Any other remarks on the example I gave, or do you think it would be a good flow of working? Maybe we could add it as an example in any of the reference projects on how to set up it.tests with a feature file

>  Multi-feature aggregation: add <featureFiles>, <features>
> ----------------------------------------------------------
>
>                 Key: SLING-13233
>                 URL: https://issues.apache.org/jira/browse/SLING-13233
>             Project: Sling
>          Issue Type: New Feature
>    Affects Versions: Feature Launcher Maven Plugin 1.0.4
>            Reporter: Roy Teeuwen
>            Assignee: Roy Teeuwen
>            Priority: Major
>             Fix For: Feature Launcher Maven Plugin 1.0.6
>
>
> The <launch> element currently accepts exactly one of <feature> (Maven coordinates) or <featureFile> (local path), validated as mutually exclusive.
> This forces users who want to aggregate (e.g. Sling Starter + a downstream feature, or a base feature + tweaks) to either:
>  * Pre-merge externally with a script that calls FeatureBuilder.assemble themselves, then point <featureFile> at the result, or
>  * Skip the plugin entirely and shell out to the launcher tar.gz with their own arg construction.
>  Both lose the plugin's start/stop lifecycle, attached-artifacts dir, port/repo plumbing, and JAVA_HOME fallback.
> This feature is meant to add the capabilities that the CLI already supports (add <featureFiles>, <features>)
> Backward compatibility: The only meaningful semantic change: combining <feature> and <featureFile> was previously rejected at validation; now it's accepted as a two-feature aggregation. Existing single-feature configurations continue to work unchanged. The new fields are all optional with empty-list / false defaults.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)