You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/02 18:09:04 UTC

[GitHub] [superset] m-ajay opened a new pull request #14952: [WIP] (fix)explore: Explore page boolean filter is broken for Preset DB

m-ajay opened a new pull request #14952:
URL: https://github.com/apache/superset/pull/14952


   ### SUMMARY
   Explore page boolean filter was not working for presto db even after the PR https://github.com/apache/superset/pull/14567. #10098  
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Will add
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c815457) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **increase** coverage by `0.13%`.
   > The diff coverage is `89.41%`.
   
   > :exclamation: Current head c815457 differs from pull request most recent head 8fa4259. Consider uploading reports for the commit 8fa4259 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   + Coverage   77.51%   77.64%   +0.13%     
   ==========================================
     Files         966      966              
     Lines       49615    49629      +14     
     Branches     6311     6314       +3     
   ==========================================
   + Hits        38458    38536      +78     
   + Misses      10956    10892      -64     
     Partials      201      201              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `81.70% <72.72%> (+0.06%)` | :arrow_up: |
   | postgres | `81.73% <72.72%> (+0.06%)` | :arrow_up: |
   | presto | `81.42% <72.72%> (?)` | |
   | python | `81.99% <72.72%> (+0.24%)` | :arrow_up: |
   | sqlite | `81.35% <72.72%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `94.73% <ø> (ø)` | |
   | [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `77.77% <0.00%> (ø)` | |
   | [.../components/ErrorMessage/ParameterErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1BhcmFtZXRlckVycm9yTWVzc2FnZS50c3g=) | `96.87% <ø> (ø)` | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `85.71% <ø> (ø)` | |
   | [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `92.15% <ø> (ø)` | |
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.91% <ø> (ø)` | |
   | [superset/utils/mock\_data.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvbW9ja19kYXRhLnB5) | `25.18% <25.00%> (+0.18%)` | :arrow_up: |
   | ... and [28 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...8fa4259](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e83fa38) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **increase** coverage by `0.01%`.
   > The diff coverage is `73.74%`.
   
   > :exclamation: Current head e83fa38 differs from pull request most recent head 987088f. Consider uploading reports for the commit 987088f to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   + Coverage   77.51%   77.52%   +0.01%     
   ==========================================
     Files         966      966              
     Lines       49615    49670      +55     
     Branches     6311     6326      +15     
   ==========================================
   + Hits        38458    38506      +48     
   - Misses      10956    10964       +8     
   + Partials      201      200       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.73% <73.83%> (-0.05%)` | :arrow_down: |
   | mysql | `81.70% <72.72%> (+0.06%)` | :arrow_up: |
   | postgres | `81.73% <72.72%> (+0.06%)` | :arrow_up: |
   | python | `81.81% <72.72%> (+0.06%)` | :arrow_up: |
   | sqlite | `81.35% <72.72%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `94.73% <ø> (ø)` | |
   | [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `77.77% <0.00%> (ø)` | |
   | [.../components/ErrorMessage/ParameterErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1BhcmFtZXRlckVycm9yTWVzc2FnZS50c3g=) | `96.87% <ø> (ø)` | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `85.71% <ø> (ø)` | |
   | [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `92.15% <ø> (ø)` | |
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `90.00% <0.00%> (-10.00%)` | :arrow_down: |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.91% <ø> (ø)` | |
   | ... and [19 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...987088f](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (153dc84) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **increase** coverage by `0.15%`.
   > The diff coverage is `97.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   + Coverage   77.51%   77.66%   +0.15%     
   ==========================================
     Files         966      966              
     Lines       49615    49615              
     Branches     6311     6311              
   ==========================================
   + Hits        38458    38534      +76     
   + Misses      10956    10880      -76     
     Partials      201      201              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `81.36% <ø> (?)` | |
   | mysql | `81.63% <ø> (ø)` | |
   | postgres | `81.66% <ø> (ø)` | |
   | python | `82.03% <ø> (+0.29%)` | :arrow_up: |
   | sqlite | `81.27% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.04% <ø> (+0.12%)` | :arrow_up: |
   | [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `97.01% <95.45%> (ø)` | |
   | [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `100.00% <100.00%> (ø)` | |
   | [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `45.38% <100.00%> (ø)` | |
   | [superset-frontend/src/explore/constants.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLnRz) | `100.00% <100.00%> (ø)` | |
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <100.00%> (ø)` | |
   | ... and [10 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...153dc84](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] etr2460 commented on a change in pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #14952:
URL: https://github.com/apache/superset/pull/14952#discussion_r647532301



##########
File path: superset-frontend/src/explore/constants.ts
##########
@@ -28,49 +28,80 @@ export const AGGREGATES = {
 };
 export const AGGREGATES_OPTIONS = Object.values(AGGREGATES);
 
-export const OPERATORS = {
-  '==': '==',
-  '!=': '!=',
-  '>': '>',
-  '<': '<',
-  '>=': '>=',
-  '<=': '<=',
-  IN: 'IN',
-  'NOT IN': 'NOT IN',
-  ILIKE: 'ILIKE',
-  LIKE: 'LIKE',
-  REGEX: 'REGEX',
-  'IS NOT NULL': 'IS NOT NULL',
-  'IS NULL': 'IS NULL',
-  'LATEST PARTITION': 'LATEST PARTITION',
-  'IS TRUE': 'IS TRUE',
-  'IS FALSE': 'IS FALSE',
+export enum Operators {
+  EQUALS = 1,

Review comment:
       if we're using this as an id, then for ease of debugging, i think i'd prefer using
   ```
   EQUALS = 'EQUALS',
   NOT_EQUALS = 'NOT_EQUALS',
   etc.
   ```
   

##########
File path: superset-frontend/src/explore/constants.ts
##########
@@ -28,49 +28,80 @@ export const AGGREGATES = {
 };
 export const AGGREGATES_OPTIONS = Object.values(AGGREGATES);
 
-export const OPERATORS = {
-  '==': '==',
-  '!=': '!=',
-  '>': '>',
-  '<': '<',
-  '>=': '>=',
-  '<=': '<=',
-  IN: 'IN',
-  'NOT IN': 'NOT IN',
-  ILIKE: 'ILIKE',
-  LIKE: 'LIKE',
-  REGEX: 'REGEX',
-  'IS NOT NULL': 'IS NOT NULL',
-  'IS NULL': 'IS NULL',
-  'LATEST PARTITION': 'LATEST PARTITION',
-  'IS TRUE': 'IS TRUE',
-  'IS FALSE': 'IS FALSE',
+export enum Operators {
+  EQUALS = 1,
+  NOT_EQUALS,
+  LESS_THAN,
+  GREATER_THAN,
+  LESS_THAN_OR_EQUAL,
+  GREATER_THAN_OR_EQUAL,
+  IN,
+  NOT_IN,
+  ILIKE,
+  LIKE,
+  REGEX,
+  IS_NOT_NULL,
+  IS_NULL,
+  LATEST_PARTITION,
+  IS_TRUE,
+  IS_FALSE,
+}
+
+export interface OperatorType {
+  display: string;
+  operation: string;
+}
+
+export const OPERATOR_MAPPING: {

Review comment:
       Not sure about this naming, perhaps `OPERATOR_ENUM_TO_OPERATOR_TYPE`?

##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx
##########
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+/* eslint-disable no-unused-expressions */
+import React from 'react';
+import sinon from 'sinon';
+import { shallow } from 'enzyme';
+
+import AdhocFilter, {
+  EXPRESSION_TYPES,
+  CLAUSES,
+} from 'src/explore/components/controls/FilterControl/AdhocFilter';
+import { AGGREGATES, Operators, OPERATOR_MAPPING } from 'src/explore/constants';
+import AdhocMetric from 'src/explore/components/controls/MetricControl/AdhocMetric';
+import AdhocFilterEditPopoverSimpleTabContent, {
+  useSimpleTabFilterProps,
+} from '.';
+
+const simpleAdhocFilter = new AdhocFilter({
+  expressionType: EXPRESSION_TYPES.SIMPLE,
+  subject: 'value',
+  operatorId: Operators.GREATER_THAN,
+  operator: OPERATOR_MAPPING[Operators.GREATER_THAN].operation,
+  comparator: '10',
+  clause: CLAUSES.WHERE,
+});
+
+const simpleMultiAdhocFilter = new AdhocFilter({
+  expressionType: EXPRESSION_TYPES.SIMPLE,
+  subject: 'value',
+  operatorId: Operators.IN,
+  operator: OPERATOR_MAPPING[Operators.IN].operation,
+  comparator: ['10'],
+  clause: CLAUSES.WHERE,
+});
+
+const sumValueAdhocMetric = new AdhocMetric({
+  expressionType: EXPRESSION_TYPES.SIMPLE,
+  column: { type: 'VARCHAR(255)', column_name: 'source' },
+  aggregate: AGGREGATES.SUM,
+});
+
+const simpleCustomFilter = new AdhocFilter({
+  expressionType: EXPRESSION_TYPES.SIMPLE,
+  subject: 'ds',
+  operator: 'LATEST PARTITION',
+  operatorId: Operators.LATEST_PARTITION,
+});
+
+const options = [
+  { type: 'VARCHAR(255)', column_name: 'source', id: 1 },
+  { type: 'VARCHAR(255)', column_name: 'target', id: 2 },
+  { type: 'DOUBLE', column_name: 'value', id: 3 },
+  { saved_metric_name: 'my_custom_metric', id: 4 },
+  sumValueAdhocMetric,
+];
+
+function setup(overrides?: object) {

Review comment:
       Prefer `Record<string, any>` to `object`

##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx
##########
@@ -0,0 +1,476 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { NativeSelect as Select } from 'src/components/Select';
+import { t, SupersetClient, styled, JsonObject } from '@superset-ui/core';
+import {
+  Operators,
+  OPERATORS_OPTIONS,
+  TABLE_ONLY_OPERATORS,
+  DRUID_ONLY_OPERATORS,
+  HAVING_OPERATORS,
+  MULTI_OPERATORS,
+  CUSTOM_OPERATORS,
+  DISABLE_INPUT_OPERATORS,
+  AGGREGATES,
+  OPERATOR_MAPPING,
+} from 'src/explore/constants';
+import FilterDefinitionOption from 'src/explore/components/controls/MetricControl/FilterDefinitionOption';
+import AdhocFilter, {
+  EXPRESSION_TYPES,
+  CLAUSES,
+} from 'src/explore/components/controls/FilterControl/AdhocFilter';
+import { Input, SelectProps } from 'src/common/components';
+
+const SelectWithLabel = styled(Select)`
+  .ant-select-selector {
+    margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
+  }
+
+  .ant-select-selector::after {
+    content: '${(
+      pr: SelectProps<any> & {
+        labelText: string | boolean;
+      },
+    ) => pr.labelText || '\\A0'}';
+    display: inline-block;
+    white-space: nowrap;
+    color: ${({ theme }) => theme.colors.grayscale.light1};
+    width: max-content;
+  }
+`;
+
+export interface SimpleColumnType {
+  id: number;
+  column_name: string;
+  expression?: string;
+  type: string;
+  optionName?: string;
+  filterBy?: string;
+  value?: string;
+}
+
+export interface SimpleExpressionType {
+  expressionType: keyof typeof EXPRESSION_TYPES;
+  column: SimpleColumnType;
+  aggregate: keyof typeof AGGREGATES;
+  label: string;
+}
+export interface SQLExpressionType {
+  expressionType: keyof typeof EXPRESSION_TYPES;
+  sqlExpression: string;
+  label: string;
+}
+
+export interface MetricColumnType {
+  saved_metric_name: string;
+}
+
+export type ColumnType =
+  | SimpleColumnType
+  | SimpleExpressionType
+  | SQLExpressionType
+  | MetricColumnType;
+
+export interface Props {
+  adhocFilter: AdhocFilter;
+  onChange: (filter: AdhocFilter) => void;
+  options: ColumnType[];
+  datasource: {
+    id: string;
+    columns: SimpleColumnType[];
+    type: string;
+    filter_select: boolean;
+  };
+  partitionColumn: string;
+}
+export const useSimpleTabFilterProps = (props: Props) => {
+  const isOperatorRelevant = (operator: Operators, subject: string) => {
+    const column = props.datasource.columns?.find(
+      col => col.column_name === subject,
+    );
+    const isColumnBoolean =
+      !!column && (column.type === 'BOOL' || column.type === 'BOOLEAN');
+    const isColumnNumber = !!column && column.type === 'INT';
+    const isColumnFunction = !!column && !!column.expression;
+
+    if (operator && CUSTOM_OPERATORS.has(operator)) {
+      const { partitionColumn } = props;
+      return partitionColumn && subject && subject === partitionColumn;
+    }
+    if (operator === Operators.IS_TRUE || operator === Operators.IS_FALSE) {
+      return isColumnBoolean || isColumnNumber || isColumnFunction;
+    }
+    if (isColumnBoolean) {
+      return (
+        operator === Operators.IS_NULL || operator === Operators.IS_NOT_NULL
+      );
+    }
+    return !(
+      (props.datasource.type === 'druid' &&
+        TABLE_ONLY_OPERATORS.indexOf(operator) >= 0) ||
+      (props.datasource.type === 'table' &&
+        DRUID_ONLY_OPERATORS.indexOf(operator) >= 0) ||
+      (props.adhocFilter.clause === CLAUSES.HAVING &&
+        HAVING_OPERATORS.indexOf(operator) === -1)
+    );
+  };
+  const onSubjectChange = (id: string) => {
+    const option = props.options.find(
+      // @ts-ignore

Review comment:
       Why is the `ts-ignore` needed here? Can we type option as `ColumnType` to get around it?

##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx
##########
@@ -0,0 +1,476 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { NativeSelect as Select } from 'src/components/Select';
+import { t, SupersetClient, styled, JsonObject } from '@superset-ui/core';
+import {
+  Operators,
+  OPERATORS_OPTIONS,
+  TABLE_ONLY_OPERATORS,
+  DRUID_ONLY_OPERATORS,
+  HAVING_OPERATORS,
+  MULTI_OPERATORS,
+  CUSTOM_OPERATORS,
+  DISABLE_INPUT_OPERATORS,
+  AGGREGATES,
+  OPERATOR_MAPPING,
+} from 'src/explore/constants';
+import FilterDefinitionOption from 'src/explore/components/controls/MetricControl/FilterDefinitionOption';
+import AdhocFilter, {
+  EXPRESSION_TYPES,
+  CLAUSES,
+} from 'src/explore/components/controls/FilterControl/AdhocFilter';
+import { Input, SelectProps } from 'src/common/components';
+
+const SelectWithLabel = styled(Select)`
+  .ant-select-selector {
+    margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
+  }
+
+  .ant-select-selector::after {
+    content: '${(
+      pr: SelectProps<any> & {
+        labelText: string | boolean;
+      },
+    ) => pr.labelText || '\\A0'}';
+    display: inline-block;
+    white-space: nowrap;
+    color: ${({ theme }) => theme.colors.grayscale.light1};
+    width: max-content;
+  }
+`;
+
+export interface SimpleColumnType {
+  id: number;
+  column_name: string;
+  expression?: string;
+  type: string;
+  optionName?: string;
+  filterBy?: string;
+  value?: string;
+}
+
+export interface SimpleExpressionType {
+  expressionType: keyof typeof EXPRESSION_TYPES;
+  column: SimpleColumnType;
+  aggregate: keyof typeof AGGREGATES;
+  label: string;
+}
+export interface SQLExpressionType {
+  expressionType: keyof typeof EXPRESSION_TYPES;
+  sqlExpression: string;
+  label: string;
+}
+
+export interface MetricColumnType {
+  saved_metric_name: string;
+}
+
+export type ColumnType =
+  | SimpleColumnType
+  | SimpleExpressionType
+  | SQLExpressionType
+  | MetricColumnType;
+
+export interface Props {
+  adhocFilter: AdhocFilter;
+  onChange: (filter: AdhocFilter) => void;
+  options: ColumnType[];
+  datasource: {
+    id: string;
+    columns: SimpleColumnType[];
+    type: string;
+    filter_select: boolean;
+  };
+  partitionColumn: string;
+}
+export const useSimpleTabFilterProps = (props: Props) => {
+  const isOperatorRelevant = (operator: Operators, subject: string) => {
+    const column = props.datasource.columns?.find(
+      col => col.column_name === subject,
+    );
+    const isColumnBoolean =
+      !!column && (column.type === 'BOOL' || column.type === 'BOOLEAN');
+    const isColumnNumber = !!column && column.type === 'INT';
+    const isColumnFunction = !!column && !!column.expression;
+
+    if (operator && CUSTOM_OPERATORS.has(operator)) {
+      const { partitionColumn } = props;
+      return partitionColumn && subject && subject === partitionColumn;
+    }
+    if (operator === Operators.IS_TRUE || operator === Operators.IS_FALSE) {
+      return isColumnBoolean || isColumnNumber || isColumnFunction;
+    }
+    if (isColumnBoolean) {
+      return (
+        operator === Operators.IS_NULL || operator === Operators.IS_NOT_NULL
+      );
+    }
+    return !(
+      (props.datasource.type === 'druid' &&
+        TABLE_ONLY_OPERATORS.indexOf(operator) >= 0) ||
+      (props.datasource.type === 'table' &&
+        DRUID_ONLY_OPERATORS.indexOf(operator) >= 0) ||
+      (props.adhocFilter.clause === CLAUSES.HAVING &&
+        HAVING_OPERATORS.indexOf(operator) === -1)
+    );
+  };
+  const onSubjectChange = (id: string) => {
+    const option = props.options.find(
+      // @ts-ignore
+      option => option.id === id || option.optionName === id,
+    );
+
+    let subject = '';
+    let clause;
+    // infer the new clause based on what subject was selected.
+    if (option && 'column_name' in option) {
+      subject = option.column_name;
+      clause = CLAUSES.WHERE;
+    } else if (option && 'saved_metric_name' in option) {
+      subject = option.saved_metric_name;
+      clause = CLAUSES.HAVING;
+    } else if (option && option.label) {
+      subject = option.label;
+      clause = CLAUSES.HAVING;
+    }
+    const { operator, operatorId } = props.adhocFilter;
+    props.onChange(
+      props.adhocFilter.duplicateWith({
+        subject,
+        clause,
+        operator:
+          operator && isOperatorRelevant(operatorId, subject)
+            ? OPERATOR_MAPPING[operatorId].operation
+            : null,
+        expressionType: EXPRESSION_TYPES.SIMPLE,
+        operatorId,
+      }),
+    );
+  };
+  const onOperatorChange = (operatorId: Operators) => {
+    const currentComparator = props.adhocFilter.comparator;
+    let newComparator;
+    // convert between list of comparators and individual comparators
+    // (e.g. `in ('North America', 'Africa')` to `== 'North America'`)
+    if (MULTI_OPERATORS.has(operatorId)) {
+      newComparator = Array.isArray(currentComparator)
+        ? currentComparator
+        : [currentComparator].filter(element => element);
+    } else {
+      newComparator = Array.isArray(currentComparator)
+        ? currentComparator[0]
+        : currentComparator;
+    }
+    if (operatorId === Operators.IS_TRUE || operatorId === Operators.IS_FALSE) {
+      newComparator = Operators.IS_TRUE === operatorId;
+    }
+    if (operatorId && CUSTOM_OPERATORS.has(operatorId)) {
+      props.onChange(
+        props.adhocFilter.duplicateWith({
+          subject: props.adhocFilter.subject,
+          clause: CLAUSES.WHERE,
+          operatorId,
+          operator: OPERATOR_MAPPING[operatorId].operation,
+          expressionType: EXPRESSION_TYPES.SQL,
+          datasource: props.datasource,
+        }),
+      );
+    } else {
+      props.onChange(
+        props.adhocFilter.duplicateWith({
+          operatorId,
+          operator: OPERATOR_MAPPING[operatorId].operation,
+          comparator: newComparator,
+          expressionType: EXPRESSION_TYPES.SIMPLE,
+        }),
+      );
+    }
+  };
+  const onComparatorChange = (comparator: string) => {
+    props.onChange(
+      props.adhocFilter.duplicateWith({
+        comparator,
+        expressionType: EXPRESSION_TYPES.SIMPLE,
+      }),
+    );
+  };
+  return {
+    onSubjectChange,
+    onOperatorChange,
+    onComparatorChange,
+    isOperatorRelevant,
+  };
+};
+
+const AdhocFilterEditPopoverSimpleTabContent: React.FC<Props> = props => {
+  const selectProps = {
+    name: 'select-column',
+    showSearch: true,
+  };
+  const {
+    onSubjectChange,
+    onOperatorChange,
+    isOperatorRelevant,
+    onComparatorChange,
+  } = useSimpleTabFilterProps(props);
+  const [suggestions, setSuggestions] = useState<JsonObject>([]);
+  const [abortActiveRequest, setAbortActiveRequest] = useState<
+    (() => void) | null
+  >(null);

Review comment:
       maybe out of scope, but initializing this to `NO_OP` (or maybe `noOp`, I forget how it's named in our utils file, it's basically an empty function) would prevent the need to manually set the type and to check if `abortActiveRequest` exists before calling it everytime. Seems cleaner

##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx
##########
@@ -0,0 +1,476 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { NativeSelect as Select } from 'src/components/Select';
+import { t, SupersetClient, styled, JsonObject } from '@superset-ui/core';
+import {
+  Operators,
+  OPERATORS_OPTIONS,
+  TABLE_ONLY_OPERATORS,
+  DRUID_ONLY_OPERATORS,
+  HAVING_OPERATORS,
+  MULTI_OPERATORS,
+  CUSTOM_OPERATORS,
+  DISABLE_INPUT_OPERATORS,
+  AGGREGATES,
+  OPERATOR_MAPPING,
+} from 'src/explore/constants';
+import FilterDefinitionOption from 'src/explore/components/controls/MetricControl/FilterDefinitionOption';
+import AdhocFilter, {
+  EXPRESSION_TYPES,
+  CLAUSES,
+} from 'src/explore/components/controls/FilterControl/AdhocFilter';
+import { Input, SelectProps } from 'src/common/components';
+
+const SelectWithLabel = styled(Select)`
+  .ant-select-selector {
+    margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
+  }
+
+  .ant-select-selector::after {
+    content: '${(
+      pr: SelectProps<any> & {
+        labelText: string | boolean;
+      },
+    ) => pr.labelText || '\\A0'}';
+    display: inline-block;
+    white-space: nowrap;
+    color: ${({ theme }) => theme.colors.grayscale.light1};
+    width: max-content;
+  }
+`;
+
+export interface SimpleColumnType {
+  id: number;
+  column_name: string;
+  expression?: string;
+  type: string;
+  optionName?: string;
+  filterBy?: string;
+  value?: string;
+}
+
+export interface SimpleExpressionType {
+  expressionType: keyof typeof EXPRESSION_TYPES;
+  column: SimpleColumnType;
+  aggregate: keyof typeof AGGREGATES;
+  label: string;
+}
+export interface SQLExpressionType {
+  expressionType: keyof typeof EXPRESSION_TYPES;
+  sqlExpression: string;
+  label: string;
+}
+
+export interface MetricColumnType {
+  saved_metric_name: string;
+}
+
+export type ColumnType =
+  | SimpleColumnType
+  | SimpleExpressionType
+  | SQLExpressionType
+  | MetricColumnType;
+
+export interface Props {
+  adhocFilter: AdhocFilter;
+  onChange: (filter: AdhocFilter) => void;
+  options: ColumnType[];
+  datasource: {
+    id: string;
+    columns: SimpleColumnType[];
+    type: string;
+    filter_select: boolean;
+  };
+  partitionColumn: string;
+}
+export const useSimpleTabFilterProps = (props: Props) => {
+  const isOperatorRelevant = (operator: Operators, subject: string) => {
+    const column = props.datasource.columns?.find(
+      col => col.column_name === subject,
+    );
+    const isColumnBoolean =
+      !!column && (column.type === 'BOOL' || column.type === 'BOOLEAN');
+    const isColumnNumber = !!column && column.type === 'INT';
+    const isColumnFunction = !!column && !!column.expression;
+
+    if (operator && CUSTOM_OPERATORS.has(operator)) {
+      const { partitionColumn } = props;
+      return partitionColumn && subject && subject === partitionColumn;
+    }
+    if (operator === Operators.IS_TRUE || operator === Operators.IS_FALSE) {
+      return isColumnBoolean || isColumnNumber || isColumnFunction;
+    }
+    if (isColumnBoolean) {
+      return (
+        operator === Operators.IS_NULL || operator === Operators.IS_NOT_NULL
+      );
+    }
+    return !(
+      (props.datasource.type === 'druid' &&
+        TABLE_ONLY_OPERATORS.indexOf(operator) >= 0) ||
+      (props.datasource.type === 'table' &&
+        DRUID_ONLY_OPERATORS.indexOf(operator) >= 0) ||
+      (props.adhocFilter.clause === CLAUSES.HAVING &&
+        HAVING_OPERATORS.indexOf(operator) === -1)
+    );
+  };
+  const onSubjectChange = (id: string) => {
+    const option = props.options.find(
+      // @ts-ignore
+      option => option.id === id || option.optionName === id,
+    );
+
+    let subject = '';
+    let clause;
+    // infer the new clause based on what subject was selected.
+    if (option && 'column_name' in option) {
+      subject = option.column_name;
+      clause = CLAUSES.WHERE;
+    } else if (option && 'saved_metric_name' in option) {
+      subject = option.saved_metric_name;
+      clause = CLAUSES.HAVING;
+    } else if (option && option.label) {
+      subject = option.label;
+      clause = CLAUSES.HAVING;
+    }
+    const { operator, operatorId } = props.adhocFilter;
+    props.onChange(
+      props.adhocFilter.duplicateWith({
+        subject,
+        clause,
+        operator:
+          operator && isOperatorRelevant(operatorId, subject)
+            ? OPERATOR_MAPPING[operatorId].operation
+            : null,
+        expressionType: EXPRESSION_TYPES.SIMPLE,
+        operatorId,
+      }),
+    );
+  };
+  const onOperatorChange = (operatorId: Operators) => {
+    const currentComparator = props.adhocFilter.comparator;
+    let newComparator;
+    // convert between list of comparators and individual comparators
+    // (e.g. `in ('North America', 'Africa')` to `== 'North America'`)
+    if (MULTI_OPERATORS.has(operatorId)) {
+      newComparator = Array.isArray(currentComparator)
+        ? currentComparator
+        : [currentComparator].filter(element => element);
+    } else {
+      newComparator = Array.isArray(currentComparator)
+        ? currentComparator[0]
+        : currentComparator;
+    }
+    if (operatorId === Operators.IS_TRUE || operatorId === Operators.IS_FALSE) {
+      newComparator = Operators.IS_TRUE === operatorId;
+    }
+    if (operatorId && CUSTOM_OPERATORS.has(operatorId)) {
+      props.onChange(
+        props.adhocFilter.duplicateWith({
+          subject: props.adhocFilter.subject,
+          clause: CLAUSES.WHERE,
+          operatorId,
+          operator: OPERATOR_MAPPING[operatorId].operation,
+          expressionType: EXPRESSION_TYPES.SQL,
+          datasource: props.datasource,
+        }),
+      );
+    } else {
+      props.onChange(
+        props.adhocFilter.duplicateWith({
+          operatorId,
+          operator: OPERATOR_MAPPING[operatorId].operation,
+          comparator: newComparator,
+          expressionType: EXPRESSION_TYPES.SIMPLE,
+        }),
+      );
+    }
+  };
+  const onComparatorChange = (comparator: string) => {
+    props.onChange(
+      props.adhocFilter.duplicateWith({
+        comparator,
+        expressionType: EXPRESSION_TYPES.SIMPLE,
+      }),
+    );
+  };
+  return {
+    onSubjectChange,
+    onOperatorChange,
+    onComparatorChange,
+    isOperatorRelevant,
+  };
+};
+
+const AdhocFilterEditPopoverSimpleTabContent: React.FC<Props> = props => {
+  const selectProps = {
+    name: 'select-column',
+    showSearch: true,
+  };
+  const {
+    onSubjectChange,
+    onOperatorChange,
+    isOperatorRelevant,
+    onComparatorChange,
+  } = useSimpleTabFilterProps(props);
+  const [suggestions, setSuggestions] = useState<JsonObject>([]);
+  const [abortActiveRequest, setAbortActiveRequest] = useState<
+    (() => void) | null
+  >(null);
+  const [currentSuggestionSearch, setCurrentSuggestionSearch] = useState('');
+  const [loading, setLoading] = useState(false);
+
+  useEffect(() => {
+    const refreshComparatorSuggestions = () => {
+      const { datasource } = props;
+      const col = props.adhocFilter.subject;
+      const having = props.adhocFilter.clause === CLAUSES.HAVING;
+
+      if (col && datasource && datasource.filter_select && !having) {
+        if (abortActiveRequest) {
+          abortActiveRequest();
+        }
+
+        const controller = new AbortController();
+        const { signal } = controller;
+        setAbortActiveRequest(controller.abort);
+        setLoading(true);
+
+        SupersetClient.get({
+          signal,
+          endpoint: `/superset/filter/${datasource.type}/${datasource.id}/${col}/`,
+        })
+          .then(({ json }) => {
+            setSuggestions(json);
+            setAbortActiveRequest(null);
+            setLoading(false);
+          })
+          .catch(() => {
+            setSuggestions([]);
+            setAbortActiveRequest(null);
+            setLoading(false);
+          });
+      }
+    };
+    refreshComparatorSuggestions();
+  }, [abortActiveRequest, props]);
+
+  const onInputComparatorChange = (
+    event: React.ChangeEvent<HTMLInputElement>,
+  ) => {
+    onComparatorChange(event.target.value);
+  };
+
+  const focusComparator = (
+    ref: HTMLInputElement | null,
+    shouldFocus: boolean,
+  ) => {
+    if (ref && shouldFocus) {
+      ref.focus();
+    }
+  };
+
+  const renderSubjectOptionLabel = (option: ColumnType) => (
+    <FilterDefinitionOption option={option} />
+  );
+
+  const clearSuggestionSearch = () => {
+    setCurrentSuggestionSearch('');
+  };
+
+  const getOptionsRemaining = () => {
+    const { comparator } = props.adhocFilter;
+    // if select is multi/value is array, we show the options not selected
+    const valuesFromSuggestionsLength = Array.isArray(comparator)
+      ? comparator.filter(v => suggestions.includes(v)).length
+      : 0;
+    return suggestions?.length - valuesFromSuggestionsLength ?? 0;
+  };
+  const createSuggestionsPlaceholder = () => {
+    const optionsRemaining = getOptionsRemaining();
+    const placeholder = t('%s option(s)', optionsRemaining);
+    return optionsRemaining ? placeholder : '';
+  };
+
+  let columns = props.options;
+  const { subject, operator, comparator, operatorId } = props.adhocFilter;
+  const subjectSelectProps = {
+    value: subject ?? undefined,
+    onChange: onSubjectChange,
+    notFoundContent: t(
+      'No such column found. To filter on a metric, try the Custom SQL tab.',
+    ),
+    autoFocus: !subject,
+    placeholder: '',
+  };
+
+  if (props.datasource.type === 'druid') {
+    subjectSelectProps.placeholder = t(
+      '%s column(s) and metric(s)',
+      columns.length,
+    );
+  } else {
+    // we cannot support simple ad-hoc filters for metrics because we don't know what type
+    // the value should be cast to (without knowing the output type of the aggregate, which
+    // becomes a rather complicated problem)
+    subjectSelectProps.placeholder =
+      props.adhocFilter.clause === CLAUSES.WHERE
+        ? t('%s column(s)', columns.length)
+        : t('To filter on a metric, use Custom SQL tab.');
+    columns = props.options.filter(
+      option => 'column_name' in option && option.column_name,
+    );
+  }
+
+  const operatorSelectProps = {
+    placeholder: t(
+      '%s operator(s)',
+      OPERATORS_OPTIONS.filter(op => isOperatorRelevant(op, subject)).length,
+    ),
+    value: OPERATOR_MAPPING[operatorId]?.display,
+    onChange: onOperatorChange,
+    autoFocus: !!subjectSelectProps.value && !operator,
+    name: 'select-operator',
+  };
+
+  const shouldFocusComparator =
+    !!subjectSelectProps.value && !!operatorSelectProps.value;
+
+  const comparatorSelectProps: SelectProps<any> & {
+    labelText: string | boolean;
+  } = {
+    allowClear: true,
+    showSearch: true,
+    mode: MULTI_OPERATORS.has(operatorId) ? 'tags' : undefined,
+    tokenSeparators: [',', '\n', '\t', ';'],
+    loading,
+    value: comparator,
+    onChange: onComparatorChange,
+    notFoundContent: t('Type a value here'),
+    disabled: DISABLE_INPUT_OPERATORS.includes(operatorId),
+    placeholder: createSuggestionsPlaceholder(),
+    labelText:
+      comparator && comparator.length > 0 && createSuggestionsPlaceholder(),
+    autoFocus: shouldFocusComparator,
+  };
+
+  return (
+    <>
+      <Select
+        css={theme => ({
+          marginTop: theme.gridUnit * 4,
+          marginBottom: theme.gridUnit * 4,
+        })}
+        {...selectProps}
+        {...subjectSelectProps}
+        filterOption={(input, option) =>
+          option && option.filterBy
+            ? option.filterBy.toLowerCase().indexOf(input.toLowerCase()) >= 0
+            : false
+        }
+        getPopupContainer={triggerNode => triggerNode.parentNode}
+      >
+        {columns.map(column => (
+          <Select.Option
+            value={
+              ('id' in column && column.id) ||
+              ('optionName' in column && column.optionName) ||
+              ''
+            }
+            filterBy={
+              ('saved_metric_name' in column && column.saved_metric_name) ||
+              ('column_name' in column && column.column_name) ||
+              ('label' in column && column.label)
+            }
+            key={
+              ('id' in column && column.id) ||
+              ('optionName' in column && column.optionName) ||
+              undefined
+            }
+          >
+            {renderSubjectOptionLabel(column)}
+          </Select.Option>
+        ))}
+      </Select>
+      <Select
+        css={theme => ({ marginBottom: theme.gridUnit * 4 })}
+        {...selectProps}
+        {...operatorSelectProps}
+        filterOption={(input, option) =>
+          option && option.children
+            ? option.children.toLowerCase().indexOf(input.toLowerCase()) >= 0
+            : false
+        }
+        getPopupContainer={triggerNode => triggerNode.parentNode}
+      >
+        {OPERATORS_OPTIONS.filter(op => isOperatorRelevant(op, subject)).map(
+          option => (
+            <Select.Option value={option} key={option}>
+              {OPERATOR_MAPPING[option].display}
+            </Select.Option>
+          ),
+        )}
+      </Select>
+      {MULTI_OPERATORS.has(operatorId) || suggestions.length > 0 ? (
+        <SelectWithLabel
+          data-test="adhoc-filter-simple-value"
+          {...comparatorSelectProps}
+          getPopupContainer={triggerNode => triggerNode.parentNode}
+          onSearch={val => setCurrentSuggestionSearch(val)}
+          onSelect={clearSuggestionSearch}
+          onBlur={clearSuggestionSearch}
+        >
+          {suggestions.map((suggestion: string) => (
+            <Select.Option value={suggestion} key={suggestion}>
+              {suggestion}
+            </Select.Option>
+          ))}
+
+          {/* enable selecting an option not included in suggestions */}
+          {currentSuggestionSearch &&
+            !suggestions.some(
+              (suggestion: string) => suggestion === currentSuggestionSearch,
+            ) && (
+              <Select.Option value={currentSuggestionSearch}>
+                {currentSuggestionSearch}
+              </Select.Option>
+            )}
+        </SelectWithLabel>
+      ) : (
+        <Input
+          data-test="adhoc-filter-simple-value"
+          name="filter-value"
+          ref={ref =>
+            focusComparator(
+              ref as HTMLInputElement | null,

Review comment:
       ideally we don't need to force the typing here, but it might be tricky

##########
File path: superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.jsx
##########
@@ -51,5 +51,6 @@ export default function FilterDefinitionOption({ option }) {
       />
     );
   }
+  return null;

Review comment:
       nice catch

##########
File path: superset-frontend/src/explore/components/controls/FilterControl/adhocFilterType.js
##########
@@ -17,16 +17,15 @@
  * under the License.
  */
 import PropTypes from 'prop-types';
-
-import { OPERATORS } from 'src/explore/constants';
 import { EXPRESSION_TYPES, CLAUSES } from './AdhocFilter';
 
 export default PropTypes.oneOfType([
   PropTypes.shape({
     expressionType: PropTypes.oneOf([EXPRESSION_TYPES.SIMPLE]).isRequired,
     clause: PropTypes.oneOf([CLAUSES.HAVING, CLAUSES.WHERE]).isRequired,
     subject: PropTypes.string.isRequired,
-    operator: PropTypes.oneOf(Object.keys(OPERATORS)).isRequired,
+    // TODO: Fix the type
+    // operator: PropTypes.oneOf(Object.keys(OPERATORS)).isRequired,

Review comment:
       looks like we need to fix something here?

##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.tsx
##########
@@ -0,0 +1,476 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { useEffect, useState } from 'react';
+import { NativeSelect as Select } from 'src/components/Select';
+import { t, SupersetClient, styled, JsonObject } from '@superset-ui/core';
+import {
+  Operators,
+  OPERATORS_OPTIONS,
+  TABLE_ONLY_OPERATORS,
+  DRUID_ONLY_OPERATORS,
+  HAVING_OPERATORS,
+  MULTI_OPERATORS,
+  CUSTOM_OPERATORS,
+  DISABLE_INPUT_OPERATORS,
+  AGGREGATES,
+  OPERATOR_MAPPING,
+} from 'src/explore/constants';
+import FilterDefinitionOption from 'src/explore/components/controls/MetricControl/FilterDefinitionOption';
+import AdhocFilter, {
+  EXPRESSION_TYPES,
+  CLAUSES,
+} from 'src/explore/components/controls/FilterControl/AdhocFilter';
+import { Input, SelectProps } from 'src/common/components';
+
+const SelectWithLabel = styled(Select)`
+  .ant-select-selector {
+    margin-bottom: ${({ theme }) => theme.gridUnit * 4}px;
+  }
+
+  .ant-select-selector::after {
+    content: '${(
+      pr: SelectProps<any> & {
+        labelText: string | boolean;
+      },
+    ) => pr.labelText || '\\A0'}';
+    display: inline-block;
+    white-space: nowrap;
+    color: ${({ theme }) => theme.colors.grayscale.light1};
+    width: max-content;
+  }
+`;
+
+export interface SimpleColumnType {
+  id: number;
+  column_name: string;
+  expression?: string;
+  type: string;
+  optionName?: string;
+  filterBy?: string;
+  value?: string;
+}
+
+export interface SimpleExpressionType {
+  expressionType: keyof typeof EXPRESSION_TYPES;
+  column: SimpleColumnType;
+  aggregate: keyof typeof AGGREGATES;
+  label: string;
+}
+export interface SQLExpressionType {
+  expressionType: keyof typeof EXPRESSION_TYPES;
+  sqlExpression: string;
+  label: string;
+}
+
+export interface MetricColumnType {
+  saved_metric_name: string;
+}
+
+export type ColumnType =
+  | SimpleColumnType
+  | SimpleExpressionType
+  | SQLExpressionType
+  | MetricColumnType;
+
+export interface Props {
+  adhocFilter: AdhocFilter;
+  onChange: (filter: AdhocFilter) => void;
+  options: ColumnType[];
+  datasource: {
+    id: string;
+    columns: SimpleColumnType[];
+    type: string;
+    filter_select: boolean;
+  };
+  partitionColumn: string;
+}
+export const useSimpleTabFilterProps = (props: Props) => {
+  const isOperatorRelevant = (operator: Operators, subject: string) => {
+    const column = props.datasource.columns?.find(
+      col => col.column_name === subject,
+    );
+    const isColumnBoolean =
+      !!column && (column.type === 'BOOL' || column.type === 'BOOLEAN');
+    const isColumnNumber = !!column && column.type === 'INT';
+    const isColumnFunction = !!column && !!column.expression;
+
+    if (operator && CUSTOM_OPERATORS.has(operator)) {
+      const { partitionColumn } = props;
+      return partitionColumn && subject && subject === partitionColumn;
+    }
+    if (operator === Operators.IS_TRUE || operator === Operators.IS_FALSE) {
+      return isColumnBoolean || isColumnNumber || isColumnFunction;
+    }
+    if (isColumnBoolean) {
+      return (
+        operator === Operators.IS_NULL || operator === Operators.IS_NOT_NULL
+      );
+    }
+    return !(
+      (props.datasource.type === 'druid' &&
+        TABLE_ONLY_OPERATORS.indexOf(operator) >= 0) ||
+      (props.datasource.type === 'table' &&
+        DRUID_ONLY_OPERATORS.indexOf(operator) >= 0) ||
+      (props.adhocFilter.clause === CLAUSES.HAVING &&
+        HAVING_OPERATORS.indexOf(operator) === -1)
+    );
+  };
+  const onSubjectChange = (id: string) => {
+    const option = props.options.find(
+      // @ts-ignore
+      option => option.id === id || option.optionName === id,
+    );
+
+    let subject = '';
+    let clause;
+    // infer the new clause based on what subject was selected.
+    if (option && 'column_name' in option) {
+      subject = option.column_name;
+      clause = CLAUSES.WHERE;
+    } else if (option && 'saved_metric_name' in option) {
+      subject = option.saved_metric_name;
+      clause = CLAUSES.HAVING;
+    } else if (option && option.label) {
+      subject = option.label;
+      clause = CLAUSES.HAVING;
+    }
+    const { operator, operatorId } = props.adhocFilter;
+    props.onChange(
+      props.adhocFilter.duplicateWith({
+        subject,
+        clause,
+        operator:
+          operator && isOperatorRelevant(operatorId, subject)
+            ? OPERATOR_MAPPING[operatorId].operation
+            : null,
+        expressionType: EXPRESSION_TYPES.SIMPLE,
+        operatorId,
+      }),
+    );
+  };
+  const onOperatorChange = (operatorId: Operators) => {
+    const currentComparator = props.adhocFilter.comparator;
+    let newComparator;
+    // convert between list of comparators and individual comparators
+    // (e.g. `in ('North America', 'Africa')` to `== 'North America'`)
+    if (MULTI_OPERATORS.has(operatorId)) {
+      newComparator = Array.isArray(currentComparator)
+        ? currentComparator
+        : [currentComparator].filter(element => element);
+    } else {
+      newComparator = Array.isArray(currentComparator)
+        ? currentComparator[0]
+        : currentComparator;
+    }
+    if (operatorId === Operators.IS_TRUE || operatorId === Operators.IS_FALSE) {
+      newComparator = Operators.IS_TRUE === operatorId;
+    }
+    if (operatorId && CUSTOM_OPERATORS.has(operatorId)) {
+      props.onChange(
+        props.adhocFilter.duplicateWith({
+          subject: props.adhocFilter.subject,
+          clause: CLAUSES.WHERE,
+          operatorId,
+          operator: OPERATOR_MAPPING[operatorId].operation,
+          expressionType: EXPRESSION_TYPES.SQL,
+          datasource: props.datasource,
+        }),
+      );
+    } else {
+      props.onChange(
+        props.adhocFilter.duplicateWith({
+          operatorId,
+          operator: OPERATOR_MAPPING[operatorId].operation,
+          comparator: newComparator,
+          expressionType: EXPRESSION_TYPES.SIMPLE,
+        }),
+      );
+    }
+  };
+  const onComparatorChange = (comparator: string) => {
+    props.onChange(
+      props.adhocFilter.duplicateWith({
+        comparator,
+        expressionType: EXPRESSION_TYPES.SIMPLE,
+      }),
+    );
+  };
+  return {
+    onSubjectChange,
+    onOperatorChange,
+    onComparatorChange,
+    isOperatorRelevant,
+  };
+};
+
+const AdhocFilterEditPopoverSimpleTabContent: React.FC<Props> = props => {
+  const selectProps = {
+    name: 'select-column',
+    showSearch: true,
+  };
+  const {
+    onSubjectChange,
+    onOperatorChange,
+    isOperatorRelevant,
+    onComparatorChange,
+  } = useSimpleTabFilterProps(props);
+  const [suggestions, setSuggestions] = useState<JsonObject>([]);

Review comment:
       is `JsonObject` the right thing to use here since you initialize to an empty array? Perhaps `Record<string, any>[]` is correct?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8638a9) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **increase** coverage by `0.03%`.
   > The diff coverage is `92.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   + Coverage   77.51%   77.55%   +0.03%     
   ==========================================
     Files         966      966              
     Lines       49615    49622       +7     
     Branches     6311     6311              
   ==========================================
   + Hits        38458    38482      +24     
   + Misses      10956    10939      -17     
     Partials      201      201              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `81.70% <ø> (+0.06%)` | :arrow_up: |
   | postgres | `81.73% <ø> (+0.06%)` | :arrow_up: |
   | python | `81.81% <ø> (+0.06%)` | :arrow_up: |
   | sqlite | `81.35% <ø> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.93% <ø> (+0.01%)` | :arrow_up: |
   | [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `45.38% <33.33%> (ø)` | |
   | [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `97.01% <95.45%> (ø)` | |
   | [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `100.00% <100.00%> (ø)` | |
   | [superset-frontend/src/explore/constants.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLnRz) | `100.00% <100.00%> (ø)` | |
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <100.00%> (ø)` | |
   | ... and [10 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...f8638a9](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on pull request #14952: [WIP] (fix)explore: Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-853631182


   @m-ajay Thanks for the fix. I tested this PR in dev environment. it works as expected. You can add more description and it will be ready for code review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (153dc84) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **increase** coverage by `0.15%`.
   > The diff coverage is `97.56%`.
   
   > :exclamation: Current head 153dc84 differs from pull request most recent head 987088f. Consider uploading reports for the commit 987088f to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   + Coverage   77.51%   77.66%   +0.15%     
   ==========================================
     Files         966      966              
     Lines       49615    49615              
     Branches     6311     6311              
   ==========================================
   + Hits        38458    38534      +76     
   + Misses      10956    10880      -76     
     Partials      201      201              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | hive | `81.36% <ø> (?)` | |
   | mysql | `81.63% <ø> (ø)` | |
   | postgres | `81.66% <ø> (ø)` | |
   | python | `82.03% <ø> (+0.29%)` | :arrow_up: |
   | sqlite | `81.27% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `89.04% <ø> (+0.12%)` | :arrow_up: |
   | [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `97.01% <95.45%> (ø)` | |
   | [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `100.00% <100.00%> (ø)` | |
   | [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `45.38% <100.00%> (ø)` | |
   | [superset-frontend/src/explore/constants.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLnRz) | `100.00% <100.00%> (ø)` | |
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <100.00%> (ø)` | |
   | ... and [10 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...987088f](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e221f7f) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **decrease** coverage by `0.15%`.
   > The diff coverage is `73.10%`.
   
   > :exclamation: Current head e221f7f differs from pull request most recent head f8638a9. Consider uploading reports for the commit f8638a9 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   - Coverage   77.51%   77.36%   -0.16%     
   ==========================================
     Files         966      967       +1     
     Lines       49615    49740     +125     
     Branches     6311     6351      +40     
   ==========================================
   + Hits        38458    38479      +21     
   - Misses      10956    11059     +103     
   - Partials      201      202       +1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | javascript | `72.44% <73.05%> (-0.34%)` | :arrow_down: |
   | mysql | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [superset-frontend/src/components/Button/index.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
   | [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `94.73% <ø> (ø)` | |
   | [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `77.77% <0.00%> (ø)` | |
   | [.../components/ErrorMessage/ParameterErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1BhcmFtZXRlckVycm9yTWVzc2FnZS50c3g=) | `96.87% <ø> (ø)` | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `100.00% <ø> (ø)` | |
   | [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `25.00% <0.00%> (-1.32%)` | :arrow_down: |
   | [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `85.71% <ø> (ø)` | |
   | [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `92.15% <ø> (ø)` | |
   | ... and [61 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...f8638a9](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (153dc84) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **not change** coverage.
   > The diff coverage is `97.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #14952   +/-   ##
   =======================================
     Coverage   77.51%   77.51%           
   =======================================
     Files         966      966           
     Lines       49615    49615           
     Branches     6311     6311           
   =======================================
     Hits        38458    38458           
     Misses      10956    10956           
     Partials      201      201           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `81.63% <ø> (ø)` | |
   | postgres | `81.66% <ø> (ø)` | |
   | python | `81.74% <ø> (ø)` | |
   | sqlite | `81.27% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.91% <ø> (ø)` | |
   | [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `97.01% <95.45%> (ø)` | |
   | [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `100.00% <100.00%> (ø)` | |
   | [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `45.38% <100.00%> (ø)` | |
   | [superset-frontend/src/explore/constants.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLnRz) | `100.00% <100.00%> (ø)` | |
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <100.00%> (ø)` | |
   | ... and [3 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...153dc84](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f8638a9) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **increase** coverage by `0.02%`.
   > The diff coverage is `92.85%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   + Coverage   77.51%   77.53%   +0.02%     
   ==========================================
     Files         966      966              
     Lines       49615    49594      -21     
     Branches     6311     6311              
   ==========================================
   - Hits        38458    38455       -3     
   + Misses      10956    10938      -18     
     Partials      201      201              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `81.70% <ø> (+0.06%)` | :arrow_up: |
   | postgres | `81.71% <ø> (+0.05%)` | :arrow_up: |
   | python | `81.79% <ø> (+0.05%)` | :arrow_up: |
   | sqlite | `81.35% <ø> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.93% <ø> (+0.01%)` | :arrow_up: |
   | [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `45.38% <33.33%> (ø)` | |
   | [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `97.01% <95.45%> (ø)` | |
   | [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `100.00% <100.00%> (ø)` | |
   | [superset-frontend/src/explore/constants.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLnRz) | `100.00% <100.00%> (ø)` | |
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <100.00%> (ø)` | |
   | [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.63% <0.00%> (-2.35%)` | :arrow_down: |
   | ... and [18 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...f8638a9](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] etr2460 merged pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #14952:
URL: https://github.com/apache/superset/pull/14952


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] edited a comment on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c815457) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **increase** coverage by `0.13%`.
   > The diff coverage is `89.41%`.
   
   > :exclamation: Current head c815457 differs from pull request most recent head f8638a9. Consider uploading reports for the commit f8638a9 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   + Coverage   77.51%   77.64%   +0.13%     
   ==========================================
     Files         966      966              
     Lines       49615    49629      +14     
     Branches     6311     6314       +3     
   ==========================================
   + Hits        38458    38536      +78     
   + Misses      10956    10892      -64     
     Partials      201      201              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `81.70% <72.72%> (+0.06%)` | :arrow_up: |
   | postgres | `81.73% <72.72%> (+0.06%)` | :arrow_up: |
   | presto | `81.42% <72.72%> (?)` | |
   | python | `81.99% <72.72%> (+0.24%)` | :arrow_up: |
   | sqlite | `81.35% <72.72%> (+0.08%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `94.73% <ø> (ø)` | |
   | [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `77.77% <0.00%> (ø)` | |
   | [.../components/ErrorMessage/ParameterErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1BhcmFtZXRlckVycm9yTWVzc2FnZS50c3g=) | `96.87% <ø> (ø)` | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
   | [...-frontend/src/explore/components/ControlHeader.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sSGVhZGVyLmpzeA==) | `85.71% <ø> (ø)` | |
   | [...trols/DateFilterControl/components/CustomFrame.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9jb21wb25lbnRzL0N1c3RvbUZyYW1lLnRzeA==) | `92.15% <ø> (ø)` | |
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.91% <ø> (ø)` | |
   | [superset/utils/mock\_data.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvbW9ja19kYXRhLnB5) | `25.18% <25.00%> (+0.18%)` | :arrow_up: |
   | ... and [28 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...f8638a9](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] codecov[bot] commented on pull request #14952: fix(explore): Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-856399269


   # [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#14952](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (153dc84) into [master](https://codecov.io/gh/apache/superset/commit/21aa3daae3e0f19fb354d67cee8777c41c908e8b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (21aa3da) will **decrease** coverage by `0.02%`.
   > The diff coverage is `97.56%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/superset/pull/14952/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #14952      +/-   ##
   ==========================================
   - Coverage   77.51%   77.49%   -0.03%     
   ==========================================
     Files         966      966              
     Lines       49615    49615              
     Branches     6311     6311              
   ==========================================
   - Hits        38458    38448      -10     
   - Misses      10956    10966      +10     
     Partials      201      201              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | mysql | `?` | |
   | postgres | `81.66% <ø> (ø)` | |
   | python | `81.70% <ø> (-0.04%)` | :arrow_down: |
   | sqlite | `81.27% <ø> (ø)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ontrols/FilterControl/AdhocFilterControl/index.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC9pbmRleC5qc3g=) | `54.61% <ø> (ø)` | |
   | [.../controls/MetricControl/FilterDefinitionOption.jsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0ZpbHRlckRlZmluaXRpb25PcHRpb24uanN4) | `100.00% <ø> (ø)` | |
   | [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.91% <ø> (ø)` | |
   | [...onents/controls/FilterControl/AdhocFilter/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyL2luZGV4Lmpz) | `97.01% <95.45%> (ø)` | |
   | [...et-frontend/src/components/Select/NativeSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L05hdGl2ZVNlbGVjdC50c3g=) | `100.00% <100.00%> (ø)` | |
   | [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `45.38% <100.00%> (ø)` | |
   | [superset-frontend/src/explore/constants.ts](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29uc3RhbnRzLnRz) | `100.00% <100.00%> (ø)` | |
   | [...uperset-frontend/src/explore/exploreUtils/index.js](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzL2luZGV4Lmpz) | `66.25% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `92.85% <0.00%> (-1.43%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.94% <0.00%> (-0.79%)` | :arrow_down: |
   | ... and [6 more](https://codecov.io/gh/apache/superset/pull/14952/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [21aa3da...153dc84](https://codecov.io/gh/apache/superset/pull/14952?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] graceguo-supercat commented on pull request #14952: [WIP] (fix)explore: Explore page boolean filter is broken for Presto DB

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #14952:
URL: https://github.com/apache/superset/pull/14952#issuecomment-853631182


   @m-ajay Thanks for the fix. I tested this PR in dev environment. it works as expected. You can add more description and it will be ready for code review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org