[jira] [Commented] (FLINK-9975) Netty dependency of Hadoop >= 2.7 is not relocated

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16563375#comment-16563375 ] 

ASF GitHub Bot commented on FLINK-9975:
---------------------------------------

NicoK opened a new pull request #6461: [FLINK-9975][hadoop] also shade Hadoop's io.netty dependency
URL: https://github.com/apache/flink/pull/6461
 
 
   ## What is the purpose of the change
   
   This is to prevent user code from clashing on Netty which we relocated in the hadoop jars using its old namespace: `org.jboss.netty`. Hadoop >= 2.7, however, upgraded Netty and relies on the new package: `io.netty`.
   
   ## Brief change log
   
   - relocate `io.netty` to `org.apache.flink.hadoop.shaded.io.netty`
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as the yarn, hdfs, and end-to-end tests.
   - I also verified the jars in the `lib/` folder contain the same dependencies (for hadoop 2.8.3) except the relocated `io.netty`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no (modifies relocation, though!)**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Netty dependency of Hadoop >= 2.7 is not relocated
> --------------------------------------------------
>
>                 Key: FLINK-9975
>                 URL: https://issues.apache.org/jira/browse/FLINK-9975
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.5.0, 1.4.2, 1.5.1, 1.6.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.6.0
>
>
> Previously, in {{flink-shaded-hadoop}}, we also relocate Netty ({{org.jboss.netty}}) to not conflict with user code. Since Hadoop 2.7 the Netty version they depend on has been upgraded and we missed relocating {{io.netty}} accordingly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)