[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7073: Adding the `asn` field to all `GET` endpoints that return a `server` object

[GitBox <gi...@apache.org>]

ocket8888 commented on code in PR #7073:
URL: https://github.com/apache/trafficcontrol/pull/7073#discussion_r974569641


##########
traffic_ops/traffic_ops_golang/deliveryservice/eligible.go:
##########
@@ -96,6 +96,15 @@ func GetServersEligible(w http.ResponseWriter, r *http.Request) {
 		api.WriteResp(w, r, v3ServerList)
 		return
 	}
+	if inf.Version.Major == 4 && inf.Version.Minor < 1 {

Review Comment:
   This causes APIv5 to return APIv4.0 structs instead of 4.1 - should check if API version is >= 4.1 instead of >=4.1 and < 5.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org