You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "eurecalulu (via GitHub)" <gi...@apache.org> on 2023/07/05 11:38:57 UTC
[GitHub] [shenyu] eurecalulu opened a new pull request, #4805: fix admin: fix menu name bug
eurecalulu opened a new pull request, #4805:
URL: https://github.com/apache/shenyu/pull/4805
This pull request mainly makes the following changes:
- Fix the menu name of the document
Before:
<img width="60%" alt="中文" src="https://github.com/apache/shenyu/assets/116816752/c90ab49e-e3b2-455f-ba36-6a7ecb4234de">
After:
<img width="30%" alt="中文" src="https://github.com/apache/shenyu/assets/116816752/28d517b5-d938-440b-9eac-9a6fa1f036c7">
<img width="29%" alt="英文" src="https://github.com/apache/shenyu/assets/116816752/789a7921-33a5-4269-a186-91afe8860176">
Make sure that:
- [x] You have read the [contribution guidelines](https://shenyu.apache.org/community/contributor-guide).
- [x] You submit test cases (unit or integration tests) that back your changes.
- [x] Your local test passed `./mvnw clean install -Dmaven.javadoc.skip=true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4805: fix admin: fix menu name bug
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4805:
URL: https://github.com/apache/shenyu/pull/4805#issuecomment-1621614190
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4805?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4805](https://app.codecov.io/gh/apache/shenyu/pull/4805?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (485963f) into [master](https://app.codecov.io/gh/apache/shenyu/commit/f36157ce300bfaba985c9cd77c5290277fa99ee1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f36157c) will **decrease** coverage by `0.38%`.
> The diff coverage is `10.86%`.
```diff
@@ Coverage Diff @@
## master #4805 +/- ##
============================================
- Coverage 65.39% 65.02% -0.38%
+ Complexity 8184 8161 -23
============================================
Files 1138 1138
Lines 33428 33457 +29
Branches 2975 2971 -4
============================================
- Hits 21861 21755 -106
- Misses 9843 9978 +135
Partials 1724 1724
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...che/shenyu/sync/data/etcd/EtcdSyncDataService.java](https://app.codecov.io/gh/apache/shenyu/pull/4805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXN5bmMtZGF0YS1jZW50ZXIvc2hlbnl1LXN5bmMtZGF0YS1ldGNkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvc3luYy9kYXRhL2V0Y2QvRXRjZFN5bmNEYXRhU2VydmljZS5qYXZh) | `62.99% <6.81%> (-12.95%)` | :arrow_down: |
| [...henyu/admin/listener/etcd/EtcdDataChangedInit.java](https://app.codecov.io/gh/apache/shenyu/pull/4805?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbGlzdGVuZXIvZXRjZC9FdGNkRGF0YUNoYW5nZWRJbml0LmphdmE=) | `100.00% <100.00%> (ø)` | |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4805/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] li-keguo merged pull request #4805: [type: fix] fix admin menu name bug
Posted by "li-keguo (via GitHub)" <gi...@apache.org>.
li-keguo merged PR #4805:
URL: https://github.com/apache/shenyu/pull/4805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org