[GitHub] [iceberg] jfz commented on a diff in pull request #5812: Use Java collections in AwsProperties to fix Kryo serialization.

[GitBox <gi...@apache.org>]

jfz commented on code in PR #5812:
URL: https://github.com/apache/iceberg/pull/5812#discussion_r976027353


##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsProperties.java:
##########
@@ -204,4 +206,21 @@ public void testS3FileIoSessionCredentialsConfiguration() {
         "secret",
         capturedAwsCredentialsProvider.resolveCredentials().secretAccessKey());
   }
+
+  @Test
+  public void testKryoSerialization() throws IOException {

Review Comment:
   The no arg constructor of AwsProperties is not in common code path, and it is overwritten in `S3FileIO.initialize()`, so usually it's not actually used if `S3FileIO.initialize()` is called.
   I think AwsProperties's no arg constructor is no longer needed? Or we can keep it and make it call the other constructor:
   `public AwsProperties() {
       this(Collections.emptyMap());
     }`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org