You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Colin Patrick McCabe (JIRA)" <ji...@apache.org> on 2012/05/11 00:14:48 UTC
[jira] [Created] (HADOOP-8388) remove unused BlockLocation
serialization
Colin Patrick McCabe created HADOOP-8388:
--------------------------------------------
Summary: remove unused BlockLocation serialization
Key: HADOOP-8388
URL: https://issues.apache.org/jira/browse/HADOOP-8388
Project: Hadoop Common
Issue Type: Bug
Affects Versions: 1.0.0
Reporter: Colin Patrick McCabe
Assignee: Colin Patrick McCabe
Priority: Minor
BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8388) Remove unused BlockLocation
serialization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8388:
--------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0
Target Version/s: (was: 2.0.0)
Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change)
Status: Resolved (was: Patch Available)
I've committed this and merged to branch-2. Thanks Colin!
> Remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8388) Remove unused BlockLocation
serialization
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272930#comment-13272930 ]
Hudson commented on HADOOP-8388:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2225 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2225/])
HADOOP-8388. Remove unused BlockLocation serialization. Contributed by Colin Patrick McCabe (Revision 1336966)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336966
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestBlockLocation.java
> Remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8388) remove unused BlockLocation
serialization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272864#comment-13272864 ]
Eli Collins commented on HADOOP-8388:
-------------------------------------
+1 pending jenkins
> remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8388) Remove unused BlockLocation
serialization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8388:
--------------------------------
Issue Type: Improvement (was: Bug)
Summary: Remove unused BlockLocation serialization (was: remove unused BlockLocation serialization)
> Remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8388) remove unused BlockLocation
serialization
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8388:
-----------------------------------------
Attachment: HADOOP-8388.001.patch
> remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8388) Remove unused BlockLocation
serialization
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272926#comment-13272926 ]
Hudson commented on HADOOP-8388:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2300 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2300/])
HADOOP-8388. Remove unused BlockLocation serialization. Contributed by Colin Patrick McCabe (Revision 1336966)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336966
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestBlockLocation.java
> Remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8388) remove unused BlockLocation
serialization
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272891#comment-13272891 ]
Hadoop QA commented on HADOOP-8388:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526437/HADOOP-8388.001.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/981//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/981//console
This message is automatically generated.
> remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8388) remove unused BlockLocation
serialization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8388:
--------------------------------
Hadoop Flags: Incompatible change
Marking incompatible since it removes an interface from a public class.
> remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8388) remove unused BlockLocation
serialization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HADOOP-8388:
--------------------------------
Target Version/s: 2.0.0
Affects Version/s: (was: 1.0.0)
2.0.0
> remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8388) Remove unused BlockLocation
serialization
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272907#comment-13272907 ]
Eli Collins commented on HADOOP-8388:
-------------------------------------
Just removes code, so no new test is necessary.
> Remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8388) Remove unused BlockLocation
serialization
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273232#comment-13273232 ]
Hudson commented on HADOOP-8388:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1040 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1040/])
HADOOP-8388. Remove unused BlockLocation serialization. Contributed by Colin Patrick McCabe (Revision 1336966)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336966
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestBlockLocation.java
> Remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8388) Remove unused BlockLocation
serialization
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272956#comment-13272956 ]
Hudson commented on HADOOP-8388:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2243 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2243/])
HADOOP-8388. Remove unused BlockLocation serialization. Contributed by Colin Patrick McCabe (Revision 1336966)
Result = ABORTED
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336966
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestBlockLocation.java
> Remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8388) Remove unused BlockLocation
serialization
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13273273#comment-13273273 ]
Hudson commented on HADOOP-8388:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1076 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1076/])
HADOOP-8388. Remove unused BlockLocation serialization. Contributed by Colin Patrick McCabe (Revision 1336966)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1336966
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestBlockLocation.java
> Remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8388) remove unused BlockLocation
serialization
Posted by "Colin Patrick McCabe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Colin Patrick McCabe updated HADOOP-8388:
-----------------------------------------
Status: Patch Available (was: Open)
> remove unused BlockLocation serialization
> -----------------------------------------
>
> Key: HADOOP-8388
> URL: https://issues.apache.org/jira/browse/HADOOP-8388
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1.0.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Priority: Minor
> Attachments: HADOOP-8388.001.patch
>
>
> BlockLocation has write, read methods but it's never serialized anywhere except in a unit test. We should removed this dead code.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira