You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/25 01:29:01 UTC
[GitHub] [airflow] xinbinhuang opened a new pull request #7861:
[AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
xinbinhuang opened a new pull request #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-604626253
Thanks @xinbinhuang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603591925
Need to rebase after https://github.com/apache/airflow/pull/7861 is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603843693
Can you rebase your PR on master please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603603258
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7861?src=pr&el=h1) Report
> Merging [#7861](https://codecov.io/gh/apache/airflow/pull/7861?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a15026fa1652bec839a03d3e33eebac1b79545ae&el=desc) will **increase** coverage by `21.15%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7861?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7861 +/- ##
===========================================
+ Coverage 65.44% 86.60% +21.15%
===========================================
Files 927 927
Lines 44963 44972 +9
===========================================
+ Hits 29425 38946 +9521
+ Misses 15538 6026 -9512
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7861?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../providers/google/cloud/secrets/secrets\_manager.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL3NlY3JldHMvc2VjcmV0c19tYW5hZ2VyLnB5) | `100.00% <100.00%> (ø)` | |
| [airflow/secrets/base\_secrets.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL2Jhc2Vfc2VjcmV0cy5weQ==) | `94.11% <100.00%> (ø)` | |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-39.44%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.69% <0.00%> (-25.26%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0.00%> (-23.53%)` | :arrow_down: |
| [airflow/providers/google/cloud/operators/vision.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL29wZXJhdG9ycy92aXNpb24ucHk=) | `99.63% <0.00%> (+0.36%)` | :arrow_up: |
| [...osoft/azure/operators/azure\_container\_instances.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL29wZXJhdG9ycy9henVyZV9jb250YWluZXJfaW5zdGFuY2VzLnB5) | `78.28% <0.00%> (+0.65%)` | :arrow_up: |
| [airflow/cli/cli\_parser.py](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY2xpX3BhcnNlci5weQ==) | `98.13% <0.00%> (+0.93%)` | :arrow_up: |
| ... and [492 more](https://codecov.io/gh/apache/airflow/pull/7861/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7861?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7861?src=pr&el=footer). Last update [a15026f...a851519](https://codecov.io/gh/apache/airflow/pull/7861?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-604610060
> @zhongjiajie @kaxil Just rebased. Going through Travis now. Should be good to go after that
Travis green!. Let me know if you have any other comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600903
Should we add `[WIP]` in PR title avoid incorrect merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
xinbinhuang commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-604072028
@zhongjiajie @kaxil Just rebased. Going through Travis now. Should be good to go after that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie removed a comment on issue #7861:
[AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
zhongjiajie removed a comment on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600912
Should we add `[WIP]` in PR title avoid incorrect merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix
CloudSecretsManagerBackend invalid connections_prefix
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #7861: [AIRFLOW-7108] Fix CloudSecretsManagerBackend invalid connections_prefix
URL: https://github.com/apache/airflow/pull/7861#issuecomment-603600912
Should we add `[WIP]` in PR title avoid incorrect merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services