You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2007/08/21 07:42:47 UTC
[jira] Commented: (MNG-2399) file size check on pom.xml (or thing
specified by --file opt) should only apply to regular files (patch
attached)
[ http://jira.codehaus.org/browse/MNG-2399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_105269 ]
Brett Porter commented on MNG-2399:
-----------------------------------
I personally have no objection to making this work, but the patch doesn't appear to be enough for me. I get:
Project ID: unknown
POM Location: /dev/stdin
Reason: Not a v4.0.0 POM. for project unknown at /dev/stdin
And among other things, Maven assumes the basedir is /dev (instead of retaining user.dir).
I think the patch will need to be more comprehensive...
> file size check on pom.xml (or thing specified by --file opt) should only apply to regular files (patch attached)
> -----------------------------------------------------------------------------------------------------------------
>
> Key: MNG-2399
> URL: http://jira.codehaus.org/browse/MNG-2399
> Project: Maven 2
> Issue Type: Bug
> Components: Command Line, General
> Affects Versions: 2.0.4
> Reporter: Alan D. Salewski
> Priority: Minor
> Fix For: 2.0.x
>
> Attachments: MNG-2399-maven-core-2.0.4.patch, MNG-2399-maven-core-trunk.patch, mvn-get-plugin
>
>
> The file size check in {{maven-core/.../org/apache/maven/DefaultMaven.java}} is applied too aggressively. In particular, it should only be applied to regular files; when reading from a unix named pipe (probably other platform-specific devices, too) we may not be able to determine the file size prior to reading the data.
> The real-world motiviation from this is the attached '{{mvn-get-plugin}}' {{bash}} script, which wants to pipe a dummy {{pom.xml}} file to {{mvn}} on {{stdin}} (by specifying {{/dev/stdin}} as the argument to the {{mvn}} {{\-\-file}} command line option).
> Once I submit this issue and have the issue number, I'll attach two patches, one against the maven svn trunk, and one against the {{maven-2.0.4}} tag.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira