You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/31 20:39:08 UTC

[GitHub] [iceberg] rdblue opened a new pull request #1282: Implement negate in bound predicates

rdblue opened a new pull request #1282:
URL: https://github.com/apache/iceberg/pull/1282


   When `in` and `notIn` predicates were added, the `negate` method was left out of the refactor that split `BoundPredicate` into `BoundLiteralPredicate`, `BoundUnaryPredicate` and `BoundSetPredicate`. This prevents operations that call `rewriteNot` from rewriting most expressions that contain not.
   
   This doesn't affect simple scans, but will cause moderately complicated workflows to fail in query planning.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on pull request #1282: Implement negate in bound predicates

Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1282:
URL: https://github.com/apache/iceberg/pull/1282#issuecomment-667347942


   FYI @rdsr, @aokolnychyi, @prodeezy. We should get a fix out for this as soon as we can.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi commented on pull request #1282: Implement negate in bound predicates

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #1282:
URL: https://github.com/apache/iceberg/pull/1282#issuecomment-667406450


   Great catch, @rdblue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] aokolnychyi merged pull request #1282: Implement negate in bound predicates

Posted by GitBox <gi...@apache.org>.
aokolnychyi merged pull request #1282:
URL: https://github.com/apache/iceberg/pull/1282


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org