[GitHub] [beam] robertwb commented on a diff in pull request #22276: Don't try to parse non-flags as retained pipeline options.

[GitBox <gi...@apache.org>]

robertwb commented on code in PR #22276:
URL: https://github.com/apache/beam/pull/22276#discussion_r922380940


##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -320,6 +320,9 @@ def get_all_options(
       while i < len(unknown_args):
         # Treat all unary flags as booleans, and all binary argument values as
         # strings.
+        if not unknown_args[i].startswith('-'):
+          i += 1
+          continue

Review Comment:
   We will look at `i+1`, which will be a fresh argument, in the next iteration of the loop. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org