You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Swapnil Ghike <sg...@linkedin.com> on 2013/11/05 23:08:02 UTC
Review Request 15248: DumpLogSegments should print absolute file path while
printing errors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15248/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1121
https://issues.apache.org/jira/browse/KAFKA-1121
Repository: kafka
Description
-------
dumplogseg
Diffs
-----
core/src/main/scala/kafka/tools/DumpLogSegments.scala 89b6cb1d0c3d9a1335184d0fc778246ce47738d3
Diff: https://reviews.apache.org/r/15248/diff/
Testing
-------
Thanks,
Swapnil Ghike
Re: Review Request 15248: DumpLogSegments should print absolute file path
while printing errors
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15248/#review28238
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Nov. 5, 2013, 10:08 p.m., Swapnil Ghike wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15248/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 10:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1121
> https://issues.apache.org/jira/browse/KAFKA-1121
>
>
> Repository: kafka
>
>
> Description
> -------
>
> dumplogseg
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/DumpLogSegments.scala 89b6cb1d0c3d9a1335184d0fc778246ce47738d3
>
> Diff: https://reviews.apache.org/r/15248/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapnil Ghike
>
>
Re: Review Request 15248: DumpLogSegments should print absolute file path
while printing errors
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15248/#review28234
-----------------------------------------------------------
Ship it!
core/src/main/scala/kafka/tools/DumpLogSegments.scala
<https://reviews.apache.org/r/15248/#comment54950>
Good catch!
- Guozhang Wang
On Nov. 5, 2013, 10:08 p.m., Swapnil Ghike wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15248/
> -----------------------------------------------------------
>
> (Updated Nov. 5, 2013, 10:08 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1121
> https://issues.apache.org/jira/browse/KAFKA-1121
>
>
> Repository: kafka
>
>
> Description
> -------
>
> dumplogseg
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/DumpLogSegments.scala 89b6cb1d0c3d9a1335184d0fc778246ce47738d3
>
> Diff: https://reviews.apache.org/r/15248/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Swapnil Ghike
>
>