You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/14 09:20:19 UTC

[GitHub] [cordova-plugin-inappbrowser] csware opened a new pull request #669: Allow App using inappbrowser to be hosted in a cross-origin iframe

csware opened a new pull request #669: Allow App using inappbrowser to be hosted in a cross-origin iframe
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/669
 
 
   ### Platforms affected
   
   Browsers such as Firefox, Chrome
   
   ### Motivation and Context
   
   Allow App using inappbrowser to be hosted in a cross-origin iframe
   
   see GH-419
   
   ### Description
   
   Prevent an uncaught exception.
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-plugin-inappbrowser] timbru31 commented on issue #669: Allow App using inappbrowser to be hosted in a cross-origin iframe

Posted by GitBox <gi...@apache.org>.
timbru31 commented on issue #669: Allow App using inappbrowser to be hosted in a cross-origin iframe
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/669#issuecomment-613490603
 
 
   The next release will be a major one - I highly doubt that we will do a minor/patch release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-plugin-inappbrowser] timbru31 merged pull request #669: Allow App using inappbrowser to be hosted in a cross-origin iframe

Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #669: Allow App using inappbrowser to be hosted in a cross-origin iframe
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/669
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org


[GitHub] [cordova-plugin-inappbrowser] csware commented on issue #669: Allow App using inappbrowser to be hosted in a cross-origin iframe

Posted by GitBox <gi...@apache.org>.
csware commented on issue #669: Allow App using inappbrowser to be hosted in a cross-origin iframe
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/669#issuecomment-613488666
 
 
   I'd prefer to have a fix in the old stable version as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org