You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "waitinfuture (via GitHub)" <gi...@apache.org> on 2024/02/18 14:08:06 UTC
[PR] [CELEBORN-1272] Do not increment epoch when retry commit [incubator-celeborn]
waitinfuture opened a new pull request, #2299:
URL: https://github.com/apache/incubator-celeborn/pull/2299
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
https://github.com/apache/incubator-celeborn/pull/2145 changes the behavior that retry commit files should use the same epoch. This PR revert the behavior back.
### Why are the changes needed?
ditto
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Passes UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1272] Do not increment epoch when retry commit [incubator-celeborn]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2299:
URL: https://github.com/apache/incubator-celeborn/pull/2299#issuecomment-1951340828
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2299?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`3f5b1de`)](https://app.codecov.io/gh/apache/incubator-celeborn/commit/3f5b1de759ff0784c580029ff537a9e2057fdcf3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 48.94% compared to head [(`2c9e93a`)](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2299?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.08%.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2299 +/- ##
==========================================
+ Coverage 48.94% 49.08% +0.14%
==========================================
Files 208 208
Lines 12893 12893
Branches 1113 1113
==========================================
+ Hits 6309 6327 +18
+ Misses 6176 6162 -14
+ Partials 408 404 -4
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-celeborn/pull/2299?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1272] Do not increment epoch when retry commit [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #2299:
URL: https://github.com/apache/incubator-celeborn/pull/2299#issuecomment-1951772763
> > #2145 changes the behavior that retry commit files should use the same epoch. This PR revert the behavior back.
>
> I think the behavior was changed by #2162?
updated, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1272] Do not increment epoch when retry commit [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture closed pull request #2299: [CELEBORN-1272] Do not increment epoch when retry commit
URL: https://github.com/apache/incubator-celeborn/pull/2299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1272] Do not increment epoch when retry commit [celeborn]
Posted by "xumingming (via GitHub)" <gi...@apache.org>.
xumingming commented on PR #2299:
URL: https://github.com/apache/celeborn/pull/2299#issuecomment-4286746277
This is correctness bug, can you help label it with "correctness"? @RexXiong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1272] Do not increment epoch when retry commit [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #2299:
URL: https://github.com/apache/incubator-celeborn/pull/2299#issuecomment-1951336470
cc @cfmcgrady @RexXiong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1272] Do not increment epoch when retry commit [incubator-celeborn]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #2299:
URL: https://github.com/apache/incubator-celeborn/pull/2299#issuecomment-1951340295
I think the behavior was changed by https://github.com/apache/incubator-celeborn/pull/2162?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1272] Do not increment epoch when retry commit [incubator-celeborn]
Posted by "waitinfuture (via GitHub)" <gi...@apache.org>.
waitinfuture commented on PR #2299:
URL: https://github.com/apache/incubator-celeborn/pull/2299#issuecomment-1953435233
Thanks, merging to main(v0.5.0)/branch-0.4(v0.4.1)/branch-0.3(v0.3.3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org