[GitHub] [rocketmq-client-cpp] ShannonDing commented on a diff in pull request #399: make message trace compatible with RocketMQ main project

[GitBox <gi...@apache.org>]

ShannonDing commented on code in PR #399:
URL: https://github.com/apache/rocketmq-client-cpp/pull/399#discussion_r925277320


##########
src/consumer/ConsumeMessageHookImpl.cpp:
##########
@@ -73,7 +74,7 @@ void ConsumeMessageHookImpl::executeHookBefore(ConsumeMessageContext* context) {
   }
   traceContext->setTimeStamp(UtilAll::currentTimeMillis());
 
-  std::string topic = TraceContant::TRACE_TOPIC + traceContext->getRegionId();
+  std::string topic = TraceContant::TRACE_TOPIC;

Review Comment:
   Trace Topic is different for local and cloud in Java SDK ：
   private String getTraceTopicName(String regionId) {
               AccessChannel accessChannel = AsyncTraceDispatcher.this.getAccessChannel();
               if (AccessChannel.CLOUD == accessChannel) {
                   return TraceConstants.TRACE_TOPIC_PREFIX + regionId;
               }
   
               return AsyncTraceDispatcher.this.getTraceTopicName();
           }



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org